Add map to pair protocols (#202)

Sources/DataStructures/Pair/Pair.swift

@@ -32,3 +32,14 @@ public protocol Pair {
     /// Creates a `Pair` with the given values.
     init(_ a: A, _ b: B)
 }
+
+extension Pair {
+
+    // MARK: - Instance Methods
+
+    /// - Returns: A `Pair` with its members transformed by the given function.
+    public func map <P,C,D> (_ f: (A,B) -> (C,D)) -> P where P: Pair, P.A == C, P.B == D {
+        let (c,d) = f(self.a, self.b)
+        return P(c,d)
+    }
+}

Sources/DataStructures/Pair/SymmetricPair.swift

@@ -17,3 +17,13 @@ extension SymmetricPair where A: Equatable {
         return a == value || b == value
     }
 }
+
+extension SymmetricPair {
+
+    // MARK: - Instance Methods
+
+    /// - Returns: A `SymmetricPair` with its members transformed by the given function.
+    public func map <P,C> (_ f: (A) -> C) -> P where P: SymmetricPair, P.A == C {
+        return P(f(self.a), f(self.b))
+    }
+}

Tests/AlgorithmsPerformanceTests/XCTestManifests.swift

@@ -2,7 +2,7 @@ import XCTest
 
 extension StableSortPerformanceTests {
     static let __allTests = [
-        ("testStableSort", testStableSort_O_nlogn),
+        ("testStableSort_O_nlogn", testStableSort_O_nlogn),
     ]
 }
 

Tests/DataStructuresTests/CrossTests.swift

@@ -30,4 +30,13 @@ class CrossTests: XCTestCase {
         XCTAssertFalse(a < b)
         XCTAssertFalse(b > a)
     }
+
+    func testMap() {
+        let start = Cross("a",2)
+        let expected = Cross(4,"aa")
+        let function: (String,Int) -> (Int,String) = { string, int in
+            (int*2, string+string)
+        }
+        XCTAssertEqual(start.map(function),expected)
+    }
 }

Tests/DataStructuresTests/PairTests/OrderedPairTests.swift

@@ -0,0 +1,18 @@
+//
+//  OrderedPairTests.swift
+//  Structure
+//
+//  Created by Benjamin Wetherfield on 15/11/2018.
+//
+
+import XCTest
+import DataStructures
+
+class OrderedPairTests: XCTestCase {
+
+    func testMap() {
+        let start = OrderedPair("a","ab")
+        let expected = OrderedPair(1,2)
+        XCTAssertEqual(start.map { $0.count }, expected)
+    }
+}

Tests/DataStructuresTests/UnorderedPairTests.swift → Tests/DataStructuresTests/PairTests/UnorderedPairTests.swift

@@ -58,6 +58,12 @@ class UnorderedPairTests: XCTestCase {
             }
         }
     }
+
+    func testMap() {
+        let start = UnorderedPair("a","ab")
+        let expected = UnorderedPair(1,2)
+        XCTAssertEqual(start.map { $0.count }, expected)
+    }
 }
 
 func randomString(maxLength: Int = 10) -> String {

Tests/DataStructuresTests/XCTestManifests.swift

@@ -35,6 +35,8 @@ extension ArrayExtensionsTests {
 
 extension BimapTests {
     static let __allTests = [
+        ("testCompose", testCompose),
+        ("testComposeOperator", testComposeOperator),
         ("testInitEmpty", testInitEmpty),
         ("testKeySubscript", testKeySubscript),
         ("testRemoveAll", testRemoveAll),
@@ -43,8 +45,6 @@ extension BimapTests {
         ("testUpdateKey", testUpdateKey),
         ("testUpdateValue", testUpdateValue),
         ("testValueSubscript", testValueSubscript),
-        ("testCompose", testCompose),
-        ("testComposeOperator", testComposeOperator),
     ]
 }
 
@@ -53,7 +53,7 @@ extension BinaryHeapTests {
         ("testBalance", testBalance),
         ("testBasicInsertPop", testBasicInsertPop),
         ("testPopNil", testPopNil),
-        ("testSimpleBalance", testSimpleBalance)
+        ("testSimpleBalance", testSimpleBalance),
     ]
 }
 
@@ -110,6 +110,7 @@ extension CrossTests {
         ("testComparableFalseEqual", testComparableFalseEqual),
         ("testComparableLexicographic", testComparableLexicographic),
         ("testComparableLexicographicFalse", testComparableLexicographicFalse),
+        ("testMap", testMap),
     ]
 }
 
@@ -282,6 +283,12 @@ extension OrderedDictionaryTests {
     ]
 }
 
+extension OrderedPairTests {
+    static let __allTests = [
+        ("testMap", testMap),
+    ]
+}
+
 extension PairsTests {
     static let __allTests = [
         ("testPairs", testPairs),
@@ -517,6 +524,7 @@ extension UnorderedPairTests {
         ("testManyHashValuesIntForCollisions", testManyHashValuesIntForCollisions),
         ("testManyHashValuesString", testManyHashValuesString),
         ("testManyHashValuesStringForCollisions", testManyHashValuesStringForCollisions),
+        ("testMap", testMap),
     ]
 }
 
@@ -581,6 +589,7 @@ public func __allTests() -> [XCTestCaseEntry] {
         testCase(MutableGraphTests.__allTests),
         testCase(NewTypeTests.__allTests),
         testCase(OrderedDictionaryTests.__allTests),
+        testCase(OrderedPairTests.__allTests),
         testCase(PairsTests.__allTests),
         testCase(QueueTests.__allTests),
         testCase(ReferenceTreeProtocolTests.__allTests),