Job Retry Project: Modifiers and MemoryModifier #11928
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
added 2 commits
July 9, 2024 17:12
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11881
Status
In development
Description
Introducing Modifiers, which is a feature of the RetryManager. The setup is analog to the Plugins. After a plugin has been selected with selectRetryAlgo, the RetryManagerPoller uses selectJobModifier, where the jobs with specific exit codes will get modified.
As for the Modifiers themselves, this PR only introduces the MemoryModifier, whose functions work towards modifying the job pkl file and the sandbox maxPSS parameter. To use it, the config file must be modified in a way similar to this:
config.RetryManager.modifiers={50660: 'MemoryModifier'}
config.RetryManager.section_('MemoryModifier')
config.RetryManager.MemoryModifier.section_()
config.RetryManager.MemoryModifier..settings = {'requiresModify': True, 'multiplyMemoryPerCore': 200, 'maxMemoryPerCore': 2000}
Is it backward compatible (if not, which system it affects?)
Maybe. I believe it is, since the modifications only imply that the list of jobs to retry will go through an extra step before actually being retried. This patch should work on previous versions without issues.
Related PRs
This is a formal PR to the development that was being worked on by @germanfgv and me in LinaresToine#3
External dependencies / deployment changes
None