Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #20610 aliasing for fields does not work #20611

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

WalterBright
Copy link
Member

Issue: #20610

@TurkeyMan I think you'll like this!

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#20611"

@WalterBright WalterBright linked an issue Dec 28, 2024 that may be closed by this pull request
@WalterBright
Copy link
Member Author

Once again, the tester does not run the test suite first, it tries to build Phobos first.

The tester should run the test suite FIRST, as it is designed to be run FIRST, not LAST.

The test suite is filled with already reduced, standalone tests. This makes it much much easier to fix a problem than trying to debug the massive tangle that is Phobos.

@dkorpel can this be fixed?

@WalterBright
Copy link
Member Author

std/experimental/allocator/common.d(144): Error: no property `Allocator` for `a` of type

@WalterBright WalterBright force-pushed the aliasSym branch 2 times, most recently from 08495f8 to e17eb15 Compare December 28, 2024 04:05
@thewilsonator
Copy link
Contributor

please use fix #20610 for PR and commit titles.

@thewilsonator thewilsonator changed the title fix Issue 20610 aliasing for fields does not work fix #20610 aliasing for fields does not work Dec 28, 2024
@WalterBright
Copy link
Member Author

please use fix #20610 for PR and commit titles

Done. Can you please fix the boilerplate message "In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)" added to every PR?

@thewilsonator
Copy link
Contributor

dlang/dlang-bot#305 (comment) I suspect that setting that array to empty is the easiest way to do that. N.B that PR was from when the transition to GitHub issues was still ongoing, it is likely to be simpler now that bugzilla is read-only.

@WalterBright WalterBright merged commit 1b9bc74 into dlang:master Dec 28, 2024
41 checks passed
@WalterBright WalterBright deleted the aliasSym branch December 28, 2024 05:39
@dkorpel
Copy link
Contributor

dkorpel commented Dec 28, 2024

@dkorpel can this be fixed?

Martin has started work on removing the test suite's Phobos dependency, but it's still WIP: #16587

I recommend running the test suite locally, you have more control and get way quicker feedback that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aliasing for fields does not work
4 participants