-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #20610 aliasing for fields does not work #20611
Conversation
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
|
Once again, the tester does not run the test suite first, it tries to build Phobos first. The tester should run the test suite FIRST, as it is designed to be run FIRST, not LAST. The test suite is filled with already reduced, standalone tests. This makes it much much easier to fix a problem than trying to debug the massive tangle that is Phobos. @dkorpel can this be fixed? |
|
08495f8
to
e17eb15
Compare
please use |
e17eb15
to
facba98
Compare
Done. Can you please fix the boilerplate message "In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)" added to every PR? |
dlang/dlang-bot#305 (comment) I suspect that setting that array to empty is the easiest way to do that. N.B that PR was from when the transition to GitHub issues was still ongoing, it is likely to be simpler now that bugzilla is read-only. |
Issue: #20610
@TurkeyMan I think you'll like this!