Fix #20601 - hasIndirections does not handle static arrays of length 0 correctly #20602
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasIndirections doesn't handle static arrays of length 0 correctly (they don't actually have any indirections), because operator precedence resulted in the check for 0 length static arrays having no actual effect.
I also copied the test for
https://issues.dlang.org/show_bug.cgi?id=12000 from std.traits to here, because it's really a compiler bug that's being tested rather than hasIndirections itself (so being in the compiler repo arguably makes more sense), and it also arguably makes more sense to put it next to the actual implementation than in std.traits where it's been.