Fix #20583 - Initialisation of @mustuse member variable causes spur…

compiler/src/dmd/mustuse.d

@@ -38,7 +38,10 @@
     {
         auto sd = sym.isStructDeclaration();
         // isStructDeclaration returns non-null for both structs and unions
-        if (sd && hasMustUseAttribute(sd, sc) && !isAssignment(e) && !isIncrementOrDecrement(e))
+        if (sd && hasMustUseAttribute(sd, sc)
+            && !isAssignment(e)
+            && !isCtorAssignment(e)
+            && !isIncrementOrDecrement(e))
         {
             error(e.loc, "ignored value of `@%s` type `%s`; prepend a `cast(void)` if intentional",
                 Id.udaMustUse.toChars(), e.type.toPrettyChars(true));
@@ -104,6 +107,25 @@
     return false;
 }
 
+/**
+ * Returns: true if `e` is an assignment that's been rewritten to a
+ * constructor call.
+ */
+private bool isCtorAssignment(Expression e)
+{
+    import dmd.id : Id;
+
+    auto comma = e.isCommaExp();
+    if (!comma)
+        return false;
+    if (!isAssignment(comma.e1))
+        return false;
+    auto call = comma.e2.isCallExp();
+    if (!call)
+        return false;
+    return call.f.ident == Id.ctor;
+}
+
 /**
  * Returns: true if id is the identifier of an assignment operator overload.
  */

compiler/test/compilable/must_use_assign.d

@@ -7,3 +7,17 @@ void test()
     S a, b;
     a = b;
 }
+
+@mustuse struct Inner
+{
+    this(int n) {}
+}
+
+struct Outer
+{
+    Inner inner;
+    this(int n)
+    {
+        this.inner = n;
+    }
+}