Stop using bower
#1830
Stop using bower
#1830
Conversation
`bower` is maintained but not recommended for use by its developers. Our `bower.json` file now only includes two dependencies: `jquery` and `jquery-flot`. At this point, `bower` is not doing much to serve the project. This patch makes the following primary changes: - Remove `bower.json` - Remove `package.json`, which only included `bower` - Put the minified source files for `jquery` and `jquery-flot` directly in `static/js/lib/` - Remove the project directories for `jquery` and `jquery-flot`. The following smaller changes are also included: - Remove `Makefile` rules related to `bower` and `jquery-flot` - Update the "JavaScript libraries" section of the `README.rst` - Remove steps related to `package.json` from `Dockerfile`
adamzap
force-pushed
the
remove-bower
branch
from
358b864 to
1fc1b38
Compare
| @@ -41,10 +41,6 @@ RUN apt-get update \ | |||
| zlib1g-dev \ | |||
| && rm -rf /var/lib/apt/lists/* | |||
|
|
|||
| # install node dependencies | |||
| COPY ./package.json ./package.json | |||
| RUN npm install | |||
There was a problem hiding this comment.
This was the only usage of npm in the Dockerfile right? I think that means we can drop the npm dependency above (L19)
There was a problem hiding this comment.
Good catch. 👀
I checked the code and the same is true for the README.
You can remove the npm install in the README.rst (L3)
https://github.com/django/djangoproject.com/blob/main/README.rst?plain=1#L23
|
Had to revert this because it failed on deploy while doing The issue is the line Either we should delete the line, or re-add the |
|
Oh wow, ok. Do you want me to delete the line and push to this branch or a new branch? |
I'm fine with either. Can a PR be reopened after it's been merged? (Also I opened a new issue to try and prevent this type of issue from happening in the future: #1831 ) |
|
I don't think I can re-open this PR. I'll open a new one. |
boweris maintained but not recommended for use by its developers. Ourbower.jsonfile now only includes two dependencies:jqueryandjquery-flot. At this point,boweris not doing much to serve the project.This patch makes the following primary changes:
bower.jsonpackage.json, which only includedbowerjqueryandjquery-flotdirectly instatic/js/lib/jqueryandjquery-flot.The following smaller changes are also included:
Makefilerules related tobowerandjquery-flotREADME.rstpackage.jsonfromDockerfilePart of #1827