-
-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #1724 -- Renamed "patch" to "pull request" #1729
base: main
Are you sure you want to change the base?
Conversation
@sarahboyce Are you OK with those new names?
|
4d77309
to
257fda8
Compare
Yes, but can we move "Easy ticket" somewhere else? Maybe into "Accepted tickets by type"?
Wordy but "Tickets with PRs needing review" would be more accurate (and "Doc. tickets with PRs needing review") |
This follows Django ticket # 35894
257fda8
to
8b8750f
Compare
I don't mind the stretch at all 😁 |
You look at the dashboard more than me (not a high bar 😁 ), so I defer to your opinion on this. |
@nessita are you happy with the naming below? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In all the cases where pull request is used I think "patch" is an more correct term. What we truly review is a patch (sometimes is a PR, something is a diff file...). But we grab a diff describing a code change and comment on it.
What's the goal of changing the term Patches in the dashboard?
This follows Django ticket # 35894