Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Translation preparation for tracdb app #1689

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Translation preparation for tracdb app #1689

wants to merge 2 commits into from

Conversation

marksweb
Copy link
Contributor

This adds translations tags to the tracdb app as suggested in #1648

@marksweb marksweb force-pushed the feat/i18n-tracdb/1648 branch 2 times, most recently from adb4d97 to 54a032f Compare November 17, 2024 02:17
bmispelon
bmispelon requested changes Nov 17, 2024
View reviewed changes
Copy link
Member

@bmispelon bmispelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Su(r)prisingly few changes in this one 🙃

The @stat(XXX) lines in tracdb/stats.py also need to be marked as translatable (they show up in the accounts/user_profile.html template).

@marksweb marksweb force-pushed the feat/i18n-tracdb/1648 branch from 54a032f to 21dea14 Compare November 17, 2024 23:58
@marksweb
Copy link
Contributor Author

@bmispelon Ok thanks - I've added those in now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmispelon bmispelon bmispelon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marksweb @bmispelon