[WIP] Unwrap execution exceptions if they have a cause #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The execution exception itself isn't a terribly useful measure of what actually happened under the hood. As a result, #111 proposed unwrapping them before finishing the future. I'm still not sure what I think of this idea, but it was straightforward enough to implement and we have some time before 0.14.x is declared final.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The execution exception itself isn't a terribly useful measure of what actually happened under the
hood. As a result, #111 proposed unwrapping them before finishing the future. I'm still not sure
what I think of this idea, but it was straightforward enough to implement and we have some time
before 0.14.x is declared final.