Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for loadBalancerIP #143

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add support for loadBalancerIP #143

wants to merge 2 commits into from

Conversation

gergaly
Copy link

@gergaly gergaly commented Nov 15, 2023 •
edited
Loading

Add loadBalancerIP field to service.yaml
closes #142

@gergaly gergaly requested a review from dirsigler as a code owner November 15, 2023 06:53
@lesmyrmidons
Copy link

👍

dirsigler
dirsigler requested changes Feb 6, 2024
View reviewed changes
Copy link
Owner

@dirsigler dirsigler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add a default value to the values.yaml like so:

service:
  type: ClusterIP
  port: 3001
  nodePort:
  annotations: {}
  loadBalancerIP:

charts/uptime-kuma/templates/service.yaml Show resolved Hide resolved
@gergaly
Copy link
Author

gergaly commented Sep 27, 2024

I've updated my fork with 'git commit --amend'. I think the pull request should be updated as well. Also added the option to the Readme.md

@dirsigler dirsigler self-requested a review December 13, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirsigler dirsigler dirsigler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for LoadBalancerIP
3 participants
@gergaly @lesmyrmidons @dirsigler