Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use so_names to prevent loading wrong abi #56

Merged
merged 1 commit into from
Nov 9, 2016

Conversation

teto
Copy link
Member

@teto teto commented Nov 8, 2016

@thehajime
Copy link
Member

Did you see particular issues with dce ? If yes, please describe in the commit message.

@teto
Copy link
Member Author

teto commented Nov 8, 2016

It was pending :)
I badly need to generate mptcp traces with the "redundant" scheduler. I wanted to use DCE for that but it badly breaks on ubuntu 16.10 (or rather with gcc6). Only with my clang branch it compiles but then some tests that used to pass now don't. This fix does not address the immediate but future problems
#57

@teto teto merged commit 688038c into direct-code-execution:master Nov 9, 2016
@teto teto deleted the sonames branch November 9, 2016 15:11
thehajime pushed a commit to thehajime/ns-3-dce that referenced this pull request Jan 12, 2018
As stated in https://bugzilla.redhat.com/show_bug.cgi?id=1361037,
"This is an application defect.

If you're using a path it's expected you know what you're loading.

One _should_ be using '#include <gnu/lib-names.h>' to get LIBC_SO and then dlopen that, it's the only supported solution, particularly consider distributions that might have /usr/lib64, or multi-arched lib dirs. You could be loading libc.so.6 from an incompatible ABI.

Loding by SONAME is the only safe option."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants