Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #55 Change tag separator to match with Shaarli #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amadeous
Copy link

@amadeous amadeous commented Jan 1, 2023

Changing ", " to " " will return a list of tags separated by " " instead of ", " when fetching tags to post link to Shaarli.

This makes it consistent with the UI instructing to use spaces as tag separator (here).

A future improvement could be to allow the user to define a specific tag separator for the current Shaarli instance they are posting to.

@amadeous amadeous changed the title Fixes #55 : Change tag separator to match with Shaarli Fixes #55 Change tag separator to match with Shaarli Jan 1, 2023
@amadeous
Copy link
Author

amadeous commented Jan 1, 2023

This PR fixes #55 (should be linked to issue but isn't for some reason).

I could try to add the future improvement mentioned above, if @dimtion is willing to integrated it to the app.

@amadeous
Copy link
Author

@dimtion Could you please moderate this PR? It should not take long (the modification is literally one char).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant