Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More chips 🥔 #1007

Merged
merged 1 commit into from
Dec 19, 2024
Merged

More chips 🥔 #1007

merged 1 commit into from
Dec 19, 2024

Conversation

SmittieC
Copy link
Collaborator

@SmittieC SmittieC commented Dec 19, 2024

Description

Add a link to the configured assistant or pipeline on experiment home

User Impact

Demo

Assistant

image

Pipeline

image

Add a link to the configured assistant or pipeline on experiment home
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/experiments/views/experiment.py 14.28% 6 Missing ⚠️
Additional details and impacted files

📢 Thoughts on this report? Let us know!

@SmittieC SmittieC merged commit 6900fbe into main Dec 19, 2024
8 checks passed
@SmittieC SmittieC deleted the cs/more_chips branch December 19, 2024 10:57
Comment on lines +190 to +194
{% if pipeline_chip %}
{% include 'generic/chip.html' with chip=pipeline_chip %}
{% elif assistant_chip %}
{% include 'generic/chip.html' with chip=assistant_chip %}
{% endif %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like you could combine these into one 'include'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants