Restore responsiveness to B5-migrated forms #35533
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it easier to associate label with field on wide screens. Restore large-screen (lg) column widths used with Bootstrap 3. Tweak medium-screen (md) column widths to improve consistency.
Should reduce the overhead of future site-wide style changes such as when upgrading Bootstrap.
It is not longer required to update BooleanFields to use BootstrapCheckboxInput since responsive horizontal forms have been restored. Indeed, when the label value is changed to an empty string (label="") it adds awkward vertical space resulting in odd layout unless the form is also properly updated to use CheckboxField (in many cases this step is missed). BootstrapCheckboxInput may optionally be used if a (new) label value is added to the left, in addition to moving the previous label value to inline_label in the widget and updating the form layout to use CheckboxField. Otherwise the default BooleanField configuration is preferred. One form was converted back to the simpler version of BooleanField (as well as restoring proper alignment of form actions) as an example in this commit. Other instances exist and may be converted in the future.
Response to 024304e
Response to 1d4cf23
Response to 202a007
Response to 3826829
Response to 3a44014
Response to 5efe4b2
Response to eec566d
Response to 4bada23
Response to 5639f83
Response to 5effc56
Response to 677ff64
Response to 6bdfb78
Response to 6d6faba
Response to 6ee6fbf
Response to 7844885
Response to e21f7fd
Response to d8b9bf6
orangejenny
added
awaiting QA
millerdev
approved these changes
Dec 18, 2024
corehq/apps/users/forms.py
Outdated
| self.helper.form_tag = False | ||
| self.helper.form_class = 'form-horizontal' |
There was a problem hiding this comment.
nit: I think this line is not needed since HQFormHelper uses that class.
There was a problem hiding this comment.
indeed, thanks - 0814e07
millerdev
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Branched off of #35519
This restores old styling for most/all of the forms where I stripped it as part of the B5 migration. I looked at every commit I've done in the past year that touched a
forms.pyfile.Safety Assurance
Safety story
UI-level changes, UI-level risk.
Automated test coverage
no
QA Plan
Will be QAed as part of https://dimagi.atlassian.net/browse/QA-7345
Rollback instructions
Labels & Review