-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Enterprise OData Report #35520
base: master
Are you sure you want to change the base?
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: corehq/apps/enterprise/enterprise.py
Did you find this useful? React with a 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good just a small question
num_feeds_available = fields.IntegerField(null=True) | ||
report_name = fields.CharField(null=True) | ||
domain = fields.CharField() | ||
report_name = fields.CharField() | ||
report_rows = fields.IntegerField(null=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw null=True
is removed from domain
and report_name
, why report_rows
still have it? I checked report_rows
will be CaseExportInstance or FormExportInstance's self.get_query().count()
, is it possible for this to return Null
?
Product Description
The previous OData Feed report contained summary fields which made normal tabular data awkward. This PR shifts the summary fields to the Domain report while modernizing the remaining fields.
Domain Report:
Domain API:
OData Feeds Report:
OData Feeds Report, too many exports:
OData Feeds API:
Technical Summary
This is being tracked by mainly https://dimagi.atlassian.net/browse/SAAS-16358 and https://dimagi.atlassian.net/browse/SAAS-16357
Safety Assurance
Safety story
Verified these changes locally
Automated test coverage
Updated previous OData Report tests
QA Plan
No QA
Rollback instructions
Labels & Review