Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Going back in browser on VerifierPlus.org has inconsistent and incorrect results #97

Closed
bmuramatsu opened this issue Sep 7, 2023 · 6 comments
Assignees

Comments

@bmuramatsu
Copy link
Collaborator

In Mac Safari Version 16.6 (17615.3.12.11.3, 17615), I see inconsistent performance when I verify JSON, select the Privacy Policy link and go back.

The most common problem is:

  1. Go to VerifierPlus.org
  2. Paste JSON to verify
  3. Go to the #verifyResult page with the credential verified
  4. Select Privacy Policy
  5. Scroll down Privacy Policy to simulate reading it
  6. Select back button in Safari
  7. Browser goes "back" to the top of the Privacy Policy yet shows the #verifyResult in URL
  8. Go back again goes back to the empty VerifierPlus.org Home Screen

There are other variations on this where I see the Privacy Policy page multiple times and other oddities. I think I've seen a case where the pasted json retained.

Attached is a screen recording of this in action. I restarted Safari before initiating this.

VerifierPlus.back.problems.on.verification.mp4
@kayaelle kayaelle moved this to Verifier Plus Backlog in DCC Engineering Sep 22, 2023
@kayaelle kayaelle moved this from Verifier Plus Backlog to To Do (Current sprint) in DCC Engineering Sep 22, 2023
@kayaelle
Copy link
Member

kayaelle commented Sep 25, 2023

I was able to replicate clicking on the back button leads to this url: https://verifierplus.org/#verify/results but the privacy content remains. Same happens when going to Terms of Use and then clicking the back button in the browser.

@bmuramatsu - do you expect that the previously verified credential would still be available upon hitting the back button or that the paste field would be empty?

Edit to question to @bmuramatsu - met with team and we will look into why the back button doesn't go back to the homepage. Once that is fixed, the expected result is that it will be an empty form not the previous result. This is because we don't store the data from state to state. It is still just a one page app. We could look into different functionality at a later date if/when we decide to make the app more robust.

@lautom36 lautom36 moved this from To Do (Current sprint) to In Progress in DCC Engineering Sep 28, 2023
@lautom36
Copy link
Contributor

pr

@kayaelle
Copy link
Member

kayaelle commented Oct 2, 2023

Can be tested here for now: https://web-verifier-plus-git-tl-97-digital-credentials-consortium.vercel.app/

The back button refreshes the app so it's a cleared form.

@kayaelle kayaelle moved this from In Progress to Ready for Review in DCC Engineering Oct 2, 2023
@kayaelle kayaelle moved this from Ready for Review to Release Ready in DCC Engineering Oct 17, 2023
@alexfigtree
Copy link
Member

Re-tested and confirmed that going from form to Privacy Policy and then hitting Back button takes user to homepage and clears form.

@alexfigtree alexfigtree moved this from Release Ready to Done in DCC Engineering Feb 21, 2024
@alexfigtree alexfigtree moved this from Done to Release Ready in DCC Engineering Feb 21, 2024
@alexfigtree
Copy link
Member

Keeping open until after deployment

@alexfigtree alexfigtree reopened this Feb 21, 2024
@alexfigtree alexfigtree moved this from Release Ready to Done (Deployed) in DCC Engineering Mar 18, 2024
@alexfigtree
Copy link
Member

Deployed on 3/18/24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done (Deployed)
Development

No branches or pull requests

7 participants