Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add onInitialized hooks for ApplicationComponent #40

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

sunshinesmilelk
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Jun 5, 2024

🦋 Changeset detected

Latest commit: 4239258

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@difizen/mana-core Patch
@difizen/mana-docs Patch
@difizen/mana-app Patch
@difizen/mana-common Patch
@difizen/mana-l10n Patch
@difizen/mana-observable Patch
@difizen/mana-react Patch
@difizen/mana-syringe Patch
@difizen/mana-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sunshinesmilelk sunshinesmilelk requested a review from BroKun June 5, 2024 12:13
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 27.43%. Comparing base (3734ce2) to head (4239258).

Files Patch % Lines
packages/mana-core/src/components/application.tsx 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   27.44%   27.43%   -0.01%     
==========================================
  Files         345      345              
  Lines       40886    40900      +14     
  Branches      955      955              
==========================================
  Hits        11222    11222              
- Misses      29664    29678      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@BroKun BroKun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BroKun BroKun merged commit 1acf757 into main Jun 5, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants