Skip to content

Commit

Permalink
fix(jupyter): load content error
Browse files Browse the repository at this point in the history
  • Loading branch information
sunshinesmilelk committed Sep 13, 2024
1 parent 5837c85 commit b71e2bb
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 2 deletions.
33 changes: 33 additions & 0 deletions .changeset/loud-jeans-pump.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
---
'@difizen/libro-codemirror': patch
'@difizen/libro-jupyter': patch
'@difizen/libro-lsp': patch
'@difizen/libro-toc': patch
'@difizen/libro-docs': patch
'@difizen/libro-code-cell': patch
'@difizen/libro-code-editor': patch
'@difizen/libro-cofine-editor': patch
'@difizen/libro-cofine-editor-contribution': patch
'@difizen/libro-cofine-editor-core': patch
'@difizen/libro-cofine-textmate': patch
'@difizen/libro-common': patch
'@difizen/libro-core': patch
'@difizen/libro-kernel': patch
'@difizen/libro-l10n': patch
'@difizen/libro-lab': patch
'@difizen/libro-language-client': patch
'@difizen/libro-markdown': patch
'@difizen/libro-markdown-cell': patch
'@difizen/libro-output': patch
'@difizen/libro-prompt-cell': patch
'@difizen/libro-raw-cell': patch
'@difizen/libro-rendermime': patch
'@difizen/libro-search': patch
'@difizen/libro-search-code-cell': patch
'@difizen/libro-shared-model': patch
'@difizen/libro-terminal': patch
'@difizen/libro-virtualized': patch
'@difizen/libro-widget': patch
---

fix(jupyter): load content error
4 changes: 2 additions & 2 deletions packages/libro-jupyter/src/libro-jupyter-model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,8 @@ export class LibroJupyterModel extends LibroModel implements ExecutableNotebookM
await this.contentsManager.deleteCheckpoint(this.filePath, checkpointID);
}

override loadNotebookContent(): Promise<INotebookContent> {
const content = super.loadNotebookContent();
override async loadNotebookContent(): Promise<INotebookContent> {
const content = await super.loadNotebookContent();
this.id = this.currentFileContents.path; // use file path as id, will be passed to editor and lsp
if (this.executable && !this.kernelConnecting) {
this.startKernelConnection();
Expand Down

0 comments on commit b71e2bb

Please sign in to comment.