Skip to content

Commit

Permalink
fix(code-editor): fix the editor in CodeEditorView is undefined
Browse files Browse the repository at this point in the history
  • Loading branch information
sunshinesmilelk authored and BroKun committed Jan 17, 2024
1 parent 7d87788 commit 262ba79
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 2 deletions.
32 changes: 32 additions & 0 deletions .changeset/purple-hats-decide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
---
'@difizen/libro-cofine-editor': patch
'@difizen/libro-code-editor': patch
'@difizen/libro-jupyter': patch
'@difizen/libro-core': patch
'@difizen/libro-lab': patch
'@difizen/libro-docs': patch
'@difizen/libro-code-cell': patch
'@difizen/libro-codemirror': patch
'@difizen/libro-cofine-editor-contribution': patch
'@difizen/libro-cofine-editor-core': patch
'@difizen/libro-cofine-textmate': patch
'@difizen/libro-common': patch
'@difizen/libro-kernel': patch
'@difizen/libro-l10n': patch
'@difizen/libro-lsp': patch
'@difizen/libro-markdown': patch
'@difizen/libro-markdown-cell': patch
'@difizen/libro-output': patch
'@difizen/libro-prompt-cell': patch
'@difizen/libro-raw-cell': patch
'@difizen/libro-rendermime': patch
'@difizen/libro-search': patch
'@difizen/libro-search-code-cell': patch
'@difizen/libro-shared-model': patch
'@difizen/libro-terminal': patch
'@difizen/libro-toc': patch
'@difizen/libro-virtualized': patch
'@difizen/libro-widget': patch
---

1. fix the editor in CodeEditorView is undefined
2 changes: 0 additions & 2 deletions packages/libro-code-editor/src/code-editor-view.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,6 @@ export class CodeEditorView extends BaseView {
};

override onViewUnmount = () => {
this.editor.dispose();

if (this.editor.dispose) {
this.editor.dispose();
}
Expand Down

0 comments on commit 262ba79

Please sign in to comment.