Opporunity title now strips special characters and ensure ordering by…

… title (#1112)

src/api/src/domain/Yoma.Core.Domain/Marketplace/Services/StoreAccessControlRuleService.cs

@@ -312,6 +312,9 @@ await _executionStrategyService.ExecuteInExecutionStrategyAsync(async () =>
         scope.Complete();
       });
 
+      if (result.Opportunities?.Count == 0) result.Opportunities = null;
+      result.Opportunities = result.Opportunities?.OrderBy(o => o.Title).ToList();
+
       _memoryCache.Remove(CacheHelper.GenerateKey<StoreAccessControlRule>());
 
       return result;
@@ -405,6 +408,7 @@ await _executionStrategyService.ExecuteInExecutionStrategyAsync(async () =>
       });
 
       if (result.Opportunities?.Count == 0) result.Opportunities = null;
+      result.Opportunities = result.Opportunities?.OrderBy(o => o.Title).ToList();
 
       _memoryCache.Remove(CacheHelper.GenerateKey<StoreAccessControlRule>());
 
@@ -721,7 +725,7 @@ private void ValidateRuleDuplicatesAcrossOrganizations(StoreAccessControlRuleReq
           var opportunityMessage = duplicateRule.OpportunityOption == StoreAccessControlRuleOpportunityCondition.All
               ? "Must complete the following opportunities:" : "Must complete at least one of the following opportunities:";
 
-          var opportunityTitles = string.Join(", ", duplicateRule.Opportunities.Select(o => o.Title));
+          var opportunityTitles = string.Join(", ", duplicateRule.Opportunities.Select(o => o.Title.RemoveSpecialCharacters()));
           reasons.Add($"{opportunityMessage} {opportunityTitles}.");
         }