Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accum value fix #3

Closed
wants to merge 9 commits into from
Closed

Accum value fix #3

wants to merge 9 commits into from

Conversation

cl0ete
Copy link
Collaborator

@cl0ete cl0ete commented Oct 29, 2024

No description provided.

ff137 and others added 9 commits October 22, 2024 15:48
* ✨ add `order_by` and `descending` options to query / scan and fetch_all methods

Signed-off-by: ff137 <[email protected]>

* ✨ add `order_by` and `descending` options to PaginatedQuerySchema

Signed-off-by: ff137 <[email protected]>

* ✨ modify `get_limit_offset` to `get_paginated_query_params`

Signed-off-by: ff137 <[email protected]>

* ✨ add ordering to InMemoryStorage scan and fetch_all methods

Signed-off-by: ff137 <[email protected]>

* 🚧 test in-progress aries-askar PR: openwallet-foundation/askar#291

Signed-off-by: ff137 <[email protected]>

* ⬆️ Update lock file

Signed-off-by: ff137 <[email protected]>

* 🎨 fix ruff warning

Signed-off-by: ff137 <[email protected]>

* ✅ fix assertions

Signed-off-by: ff137 <[email protected]>

* 🚧 test aries-askar with TestPyPI package

Signed-off-by: ff137 <[email protected]>

* 🚧 test latest askar testpypi package

Signed-off-by: ff137 <[email protected]>

* 🎨 Update order_by description and default value. Include in schema

Signed-off-by: ff137 <[email protected]>

* 🐛 fix deserialisation of descending: bool parameter

Signed-off-by: ff137 <[email protected]>

* ⏪ revert to testing 0.3.3b0 askar test package

Signed-off-by: ff137 <[email protected]>

* 🔥 remove unnecessary record sorts (now that askar sorts by id == sorting by created_at)

Signed-off-by: ff137 <[email protected]>

* ✅ fix test assertions -- wallet_list and connections_list no longer does additional sorting

Signed-off-by: ff137 <[email protected]>

* ⬆️ Update lock file

Signed-off-by: ff137 <[email protected]>

---------

Signed-off-by: ff137 <[email protected]>
Signed-off-by: Jamie Hale <[email protected]>
Signed-off-by: Jamie Hale <[email protected]>
Signed-off-by: Jamie Hale <[email protected]>
@ff137
Copy link
Collaborator

ff137 commented Nov 12, 2024

Included in 1.1.1b2 +

@ff137 ff137 closed this Nov 12, 2024
@ff137 ff137 deleted the accum-value-fix branch November 12, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants