Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to metall 0.28 #10

Merged
merged 13 commits into from
Aug 7, 2024
Merged

Update to metall 0.28 #10

merged 13 commits into from
Aug 7, 2024

Conversation

liss-h
Copy link
Collaborator

@liss-h liss-h commented Jun 25, 2024 •
edited
Loading

Update to metall 0.28 and conan 2

@liss-h liss-h force-pushed the update/metall-0.28 branch from 92ffce0 to 3d47a3a Compare June 25, 2024 08:20
@liss-h liss-h added the blocked This is blocked by another task label Jun 26, 2024
bigerl
bigerl requested changes Jul 29, 2024
View reviewed changes
Copy link
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR. Just one question about the code.

tests/tests_Sanity.cpp Outdated Show resolved Hide resolved
@liss-h liss-h removed the blocked This is blocked by another task label Aug 5, 2024
bigerl
bigerl reviewed Aug 7, 2024
View reviewed changes
Copy link
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conan changes look good.

@bigerl bigerl mentioned this pull request Aug 7, 2024
Closed
2 tasks
bigerl
bigerl approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@bigerl bigerl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready to go

@liss-h liss-h merged commit 785de42 into develop Aug 7, 2024
1 check passed
This was referenced Aug 7, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigerl bigerl bigerl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liss-h @bigerl