Fix instancing new Character Nodes on Simple Highlight Portrait #2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This portrait is simple and allows for only one image, there is no underlying node hierarchy that may need to change. Therefore, we need to ensure to not recreate a new character node.
|
This seems correct. Looks like I changed the default for this method a while ago and didn't change this implementation. Thanks. I think custom portraits that create new scenes every time should just check against the current speaker in _ready to generate the right highlight, but we could possibly add a helper method like is_current_speaker() either directly to the DialogicPortrait class or to the Portrait subsystem... |
CakeVR
deleted the
fix-instancing-character-nodes-on-simple-highlight-portrait
branch
|
This uses spaces for indentation instead of tabs causing Godot not to parse the file correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This portrait is simple and allows for only one image, there is no underlying node hierarchy that may need to change. Therefore, we need to ensure to not recreate a new character node.
We should look at handling this behaviour, to keep highlights working for other portrait scenes, that create a new character instance, too.