Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort subsystems for cleaner diffs #2467

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

salianifo
Copy link
Contributor

This just sorts the subsystems alphabetically when reloading to make cleaner diffs when using extensions that add subsystems. Also rearranges the default order of subsystems in the DialogicGameHandler.gd file.

@CakeVR CakeVR added the Enhance ⚡ Improve a feature's workflow. label Nov 11, 2024
Copy link
Collaborator

@CakeVR CakeVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting change, please look at the requested changes.

addons/dialogic/Core/DialogicUtil.gd Outdated Show resolved Hide resolved
addons/dialogic/Core/DialogicUtil.gd Outdated Show resolved Hide resolved
@salianifo
Copy link
Contributor Author

Made the requested changes 😃

@CakeVR
Copy link
Collaborator

CakeVR commented Nov 11, 2024

Amazing, thank you!

@CakeVR CakeVR merged commit 589658e into dialogic-godot:main Nov 11, 2024
3 checks passed
@salianifo salianifo deleted the sort-subsystems branch November 11, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhance ⚡ Improve a feature's workflow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants