1.x converter "jump" working by prep loop func + character "positions" debugged #2009
Conversation
metanoder
changed the title
|
Committed a fix for conversion for an empty if-statement definition. #1494 Checks if there's a definition before proceeding to look for path and name. Won't break the conversion if there's an empty if-statement definition, and proceed with the conversion, while outputting there's a problem in the converter dialog box. |
|
@metanoder Thanks for your PR. Currently I have no time to test the converter or your PR. Unfortunately @exelia-antonov who was mainly responsible for the converter has very little time these days as well. Thus, I'm going to merge this without testing. The current plan is to remove the converter from dialogic core before we go beta and just put a link to another repo hosting it. |
…" debugged (dialogic-godot#2009) * dialogic-1 converter change_timeline -> jump fix by prep loop func * 1.x vs 2.x character positions now match, converter updated * fixed empty if-statement conversion break
Tested the dialogic-1 converter today. Noticed the change_timeline() to jump conversion needed touching up.
Added a prep loop to populate a dictionary with timeline keys and file names to be able to populate the converted timeline to write out proper "jump nextTimeline/" in editor.
*Noticed the character position conversion for 2.0 now mirrors 1.x again. Deleted the +1 in the code.
**Committed a fix for conversion for an empty if-statement definition. #1494