Fix TyVar BndrVis #2622
Merged
Fix TyVar BndrVis #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhall-lang#2542 allowed `dhall` to compile with template-haskell-2.21 and GHC-9.8 by adapting to the addition of a binder visibility field on type variables. Previously all binders were taken to be required, but in GHC-9.8 the possibility of invisible binders was introduced. The above patch mistakenly set all binders generated by Dhall to be invisible, rather than default value of required. This changes the semantics of the code and broke some examples in the test suite. This patch fixes this by correctly setting binders to be BndrReq. Resolves dhall-lang#2567
|
You should also consider whether it's worth deprecating versions of dhall between this bug being introduced and fixed as users using the TH functions with GHC 9.8+ will have generated broken code. Or maybe just releasing revisions that disable the broken combination of dhall and template-haskell. |
|
This is great, thank you! Tagging @Gabriella439, not sure if you're subscribed. |
|
I am subscribed! I receive email notifications for PRs opened against this repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2542 allowed
dhallto compile with template-haskell-2.21 and GHC-9.8 by adapting to the addition of a binder visibility field on type variables.Previously all binders were taken to be required, but in GHC-9.8 the possibility of invisible binders was introduced.
The above patch mistakenly set all binders generated by Dhall to be invisible, rather than default value of required. This changes the semantics of the code and broke some examples in the test suite.
This patch fixes this by correctly setting binders to be BndrReq.
Resolves #2567