Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for binary files to to-directory-tree #2618

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

mmhat
Copy link
Collaborator

@mmhat mmhat commented Nov 29, 2024

Since Byte is part of the Dhall language we can produce binary files with the to-directory-tree command as well.
This PR implements that feature.

It also deprecates the file constructor used to construct files containing Text in favor of text-file and binary-file -- The former is what file used to be while the latter is for files containing Bytes.

@mmhat
Copy link
Collaborator Author

mmhat commented Nov 29, 2024

It happened again: The Hydra failure appears unrelated to this PR 😞

@Gabriella439
Copy link
Collaborator

Sorry about the Hydra failures 😓

I'll try to find a way to fix them (or move the build off of Hydra)

@Gabriella439 Gabriella439 merged commit 063357f into dhall-lang:main Nov 30, 2024
9 checks passed
@mmhat mmhat deleted the to-directory-tree-bytes branch December 7, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants