Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lifeline_canister.wasm URL and enable demo_latest. #137

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Fix lifeline_canister.wasm URL and enable demo_latest. #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e95067f
Fix lifeline_canister.wasm URL and enable demo_latest.
dskloetd Apr 26, 2023
85a7251
set -x in dfx-network-deploy
dskloetd Apr 26, 2023
b7ce0da
Add an extra alias for lifeline.wasm
dskloetd Apr 26, 2023
4af4a8f
Updating frontend formatting
Apr 26, 2023
37e58f9
Use dfx-nns-wasm-download
dskloetd Apr 26, 2023
cf18d91
Merge remote-tracking branch 'origin/kloet/lifeline' into kloet/lifeline
dskloetd Apr 26, 2023
4926ea8
Use --download-dir
dskloetd Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/run.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:
path: state.tar.xz
retention-days: 3
demo_latest:
if: false # Claim that snsdemo works with the latest IC repo commit (true) or acknowledge that it doesn't (false).
if: true # Claim that snsdemo works with the latest IC repo commit (true) or acknowledge that it doesn't (false).
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
Expand Down
1 change: 1 addition & 0 deletions bin/dfx-network-deploy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ if [[ "$DFX_NETWORK" == "local" ]]; then
curl "https://download.dfinity.systems/ic/${DFX_IC_COMMIT}/canisters/sns-wasm-canister.wasm.gz" | gunzip >"${WASM_DIR}/sns-wasm-canister.wasm"

dfx start --clean --background
dfx-nns-wasm-download --ic_commit "$DFX_IC_COMMIT" --download-dir "$(dfx cache show)/wasms"
dfx nns install
dfx-nns-import

Expand Down
6 changes: 3 additions & 3 deletions bin/dfx-nns-wasm-download
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ help_text() {
Default: '$DOWNLOAD_DIR'
The download dir is printed on stdout for use by other programs.

--commit <DFX_IC_COMMIT>
--ic_commit <DFX_IC_COMMIT>
Commit in the IC repo.
Note: Not all commits are available as artifacts to download.

Expand All @@ -54,7 +54,7 @@ while (($# > 0)); do
} >&2
shift 1
;;
--ic-commit)
--ic_commit)
DFX_IC_COMMIT="$1"
shift 1
;;
Expand Down Expand Up @@ -137,7 +137,7 @@ get_wasm governance-canister_test.wasm nns-governance.wasm governance-canister.w
get_wasm ledger-canister_notify-method.wasm nns-ledger.wasm
get_wasm root-canister.wasm nns-root.wasm
get_wasm cycles-minting-canister.wasm nns-cmc.wasm
get_wasm lifeline.wasm nns-lifeline.wasm
get_wasm lifeline_canister.wasm nns-lifeline.wasm lifeline.wasm
get_wasm sns-wasm-canister.wasm nns-sns-wasm.wasm
get_wasm genesis-token-canister.wasm
get_wasm identity-canister.wasm
Expand Down