feat: add "Build consent message" to demo #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demo/src/relying_party_frontend/src/lib/components/BuildConsentMessage.svelte
Show resolved
Hide resolved
| amount: 1n * (E8S_PER_ICP / 2n) | ||
| }; | ||
|
|
||
| await wallet?.icrc1Transfer({ |
There was a problem hiding this comment.
should there be an if condition beforehand to check if wallet is non-nullish? I see that you put it in the html part, but not in this function
There was a problem hiding this comment.
If the demo were a real app, yes, I would add an if statement and display an error. However, since it is primarily intended for E2E testing, ignoring the fact that the wallet would not be initialized here is acceptable. If the wallet fails to perform any action, the related test would fail to validate the process. Therefore, I think it's fine, but I don't have a strong opinion either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To test manually or with E2E test locally, it's handy to add a "Build consent message" call to action in the
/devpanel of the demo.