Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Cookies functionality with Dfeshiny cookies functions #108

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

oadetayo
Copy link
Contributor

…shiny cookies module

Pull request overview

Replace old ui and server elements for cookies with standardized dfeshiny cookies module

Pull request checklist

Please check if your PR fulfills the following:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been run locally and are passing (shinytest2::test_app())
  • Code is styled according to tidyverse styling (checked locally with styler::style_dir() and lintr::lint_dir())

What is the new behaviour?

All cookie code is handled using the dfeshiny functions
dfeshiny::init_cookies() is run to update the cookies js

@oadetayo oadetayo changed the title Replaced Cookies functionality with Dfeshiny cookies function Replaced Cookies functionality with Dfeshiny cookies functions Dec 18, 2024
server.R Fixed Show fixed Hide fixed
@oadetayo oadetayo requested a review from rmbielby December 18, 2024 12:28
Copy link
Contributor

@rmbielby rmbielby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small extra change to stop the support panel showing on the cookies panel

ui.R Outdated Show resolved Hide resolved
@rmbielby rmbielby assigned rmbielby and oadetayo and unassigned rmbielby Dec 18, 2024
@oadetayo oadetayo requested a review from rmbielby December 18, 2024 14:17
Copy link
Contributor

@rmbielby rmbielby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks.

@oadetayo oadetayo merged commit b211236 into main Dec 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants