Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to using inbuilt shiny select components #100

Open
cjrace opened this issue Dec 8, 2024 · 0 comments
Open

Change to using inbuilt shiny select components #100

cjrace opened this issue Dec 8, 2024 · 0 comments
Labels
accessibility enhancement New feature or request

Comments

@cjrace
Copy link
Contributor

cjrace commented Dec 8, 2024

Currently we use select components from shinyGovstyle. Though these are plain HTML behind the scenes and don't have additional features, for example - optimisations for larger lists.

We should instead use the selectInput / selectizeInput that comes with shiny and apply styling to ensure accessibility. Starters for this can be seen in the apprenticeships dashboard.

Key issues we should check:

  • Correct labelling markup
  • Focus indicators
  • Fonts

I'm assuming once we've worked out the main examples, we should then build in our own function into dfeshiny.

In the app we should provide two examples, one of the basic select component, and one as a combobox / multi-select. The latter is likely to have accessibility issues, though that makes it even more important to get into the template so that we can test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant