-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🛠] Package update and asset regenerate #9647
Conversation
`npm audit fix` + `gulp dev`
package.json
Outdated
"bootstrap": "^4.3.1", | ||
"font-awesome": "^4.7.0", | ||
"fsevents": "^2.1.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is what is making this break on the netlify build; do you know what pulled this in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tl;dr is that this should be somehow seen as an optional dependency (it only works on MacOS, so it's bailing on the netlify part).
Basically, even though we aren't using any of it, netlify still installs everything in package.json
when it builds the site (we cannot prevent this from happening) and the build containers aren't MacOS so ... failure.
For troubleshooting, this is also failing in the containers on CircleCI with the following:
Basically, we have to get |
Here's some more info why |
Oh right, I ran these commands on a mac, so that'd explain it. |
You're not a mac
@mattstratton builds green :) |
For a final test can you run |
@mattstratton Yes, it works, no more diffs in the code, with a local |
Should:
minimist
to >=1.2.2Does not:
Created/tested locally with:
npm audit fix
gulp dev
hugo server -w ...
And nothing seems terribly wrong.
The netlify preview will not be a complete test in this case.
Deferring to @mattstratton as an uber-reviewer