Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🛠] Package update and asset regenerate #9647

Merged
merged 2 commits into from
Mar 18, 2020
Merged

[🛠] Package update and asset regenerate #9647

merged 2 commits into from
Mar 18, 2020

Conversation

glasnt
Copy link
Member

@glasnt glasnt commented Mar 17, 2020

Should:

  • resolve github banner notification, bumping minimist to >=1.2.2
  • minor bump of 329 other packages per auto-fix (326 low, 2 moderate)
  • re-compile assets accordingly

Does not:

Created/tested locally with:

  • npm audit fix
  • gulp dev
  • hugo server -w ...

And nothing seems terribly wrong.

The netlify preview will not be a complete test in this case.

Deferring to @mattstratton as an uber-reviewer

`npm audit fix` + `gulp dev`
@glasnt glasnt requested a review from mattstratton March 17, 2020 06:00
@glasnt glasnt requested review from a team as code owners March 17, 2020 06:00
package.json Outdated
"bootstrap": "^4.3.1",
"font-awesome": "^4.7.0",
"fsevents": "^2.1.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is what is making this break on the netlify build; do you know what pulled this in?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tl;dr is that this should be somehow seen as an optional dependency (it only works on MacOS, so it's bailing on the netlify part).

Basically, even though we aren't using any of it, netlify still installs everything in package.json when it builds the site (we cannot prevent this from happening) and the build containers aren't MacOS so ... failure.

@mattstratton
Copy link
Member

For troubleshooting, this is also failing in the containers on CircleCI with the following:

npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

npm ERR! code EBADPLATFORM
npm ERR! notsup Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm ERR! notsup Valid OS:    darwin
npm ERR! notsup Valid Arch:  any
npm ERR! notsup Actual OS:   linux
npm ERR! notsup Actual Arch: x64

Basically, we have to get fsevents out of the package.json file because it's making the non-Mac build systems fail :)

@mattstratton
Copy link
Member

Here's some more info why fsevents might be bailing

fsevents/fsevents#301

@glasnt
Copy link
Member Author

glasnt commented Mar 17, 2020

Oh right, I ran these commands on a mac, so that'd explain it.

You're not a mac
@glasnt
Copy link
Member Author

glasnt commented Mar 18, 2020

@mattstratton builds green :)

@mattstratton
Copy link
Member

For a final test can you run gulp dev after removing fsevents to confirm it still works? Or do you already?

@glasnt
Copy link
Member Author

glasnt commented Mar 18, 2020

@mattstratton Yes, it works, no more diffs in the code, with a local gulp dev and hugo server -w

@mattstratton mattstratton merged commit 220a33a into devopsdays:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants