Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue related to junit #49

Merged
merged 1 commit into from
Jan 20, 2020
Merged

fixed issue related to junit #49

merged 1 commit into from
Jan 20, 2020

Conversation

vapadwal
Copy link
Member

I have updated with devon4j 3.1.1 that had fix the junit issue.
But I had to comment 2 junit test as access control has not been implemented in jumpthequeue
Below testcases has been commented
testLogin()
permissionCheckAnnotationPresent()

@vapadwal
Copy link
Member Author

build is faling as i am getting the below error
remote: Invalid username or password.

https://travis-ci.com/vapadwal/jump-the-queue/builds/144039795?utm_medium=notification&utm_source=email

@phschimm
Copy link
Member

phschimm commented Jan 13, 2020

Maybe it's because the ORG in .travis.yml in your repo is set to "devonfw".

The ORG is used as part of the ${GH_REPO_DEST} here. I'm not sure where Travis gets the ${USER} and ${GITHUB_TOKEN} parameters from, but since it's an authentication error, that might be the issue:

git remote add origin-wiki "https://${USER}:${GITHUB_TOKEN}@${GH_REPO_DEST}"
git push origin-wiki master

@phschimm
Copy link
Member

I can confirm that mvn install, mvn spring-boot:run and mvn clean package now run without error.
We should merge this @sjimenez77.

NOTE:
This doesn't fix issues #47 and #48, which occur when following the written step-by-step tutorial.
So it's a documentation issue for now and I'll remove the bug tag from the issues.

@phschimm phschimm merged commit a001a5a into devonfw:master Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants