Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#734: Improve Process Result Model #773
base: main
Are you sure you want to change the base?
#734: Improve Process Result Model #773
Changes from 6 commits
e25575f
8e66739
5c3cccb
4d5a556
daf4b45
05879d1
292aa5b
41a42ce
3da75c7
540a9b0
c2b7021
4530860
05da168
88c8ef1
4700583
f0c5b9e
4daec09
4bbb603
af6add1
8491143
d7e176e
ffd6ced
4c5f98a
dce5d5a
39de3a4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we try to read the lines again from the buffered reader after it has already been consumed to the end?
IMHO you should change the signature from
CompletableFuture<List<String>>
toCompletableFuture<Void>
and simply returnnull
here.