Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API first tutorial #192

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

GuentherJulian
Copy link
Contributor

Tutorial that shows how to create a REST API from an OpenAPI specification using OpenAPI generator

@GuentherJulian GuentherJulian self-assigned this Jan 7, 2022
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Thanks for submitting your work on a (new) tutorial!

Some suggestions, which might help:

  • Title: Focus on what you want to train in a few words. Don't be too generic
  • Tutorial:
    • Address the user directly.
    • Explain why the steps are necessary.
    • Explain what are the results and why are they necessary for your next step.
    • Forward the user to more elaborate documentation on the website (deep links) for further reading

Also please find further help for creating tutorials here or more help regarding the tutorial syntax here.

You can view the generated tutorials of this PR here in a few minutes. You just have to wait for the run of the deployment action to finish.

When you think you are done writing the tutorial try the tutorial on the deveplopment area and check if you explained every step in a way someone who is trying to learn what you are teaching can understand. Ideally ask someone to have a look on what you have done and have that part double checked because this is very important.

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

api-first-approach/index.asciidoc Outdated Show resolved Hide resolved
api-first-approach/index.asciidoc Outdated Show resolved Hide resolved
api-first-approach/index.asciidoc Show resolved Hide resolved
EduardKrieger
EduardKrieger previously approved these changes Jan 11, 2022
@@ -0,0 +1,90 @@
= API first approach with OpenAPI generator
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title/subtitle is missing the info that it is a quarkus tutorial.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is actually a 'general' tutorial. I did use Quarkus, but you can do it the same way in Spring.
I added some information about it in the description, but I would leave the title as it is.

@@ -0,0 +1,90 @@
= API first approach with OpenAPI generator
====
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tags -> see docs on how to do it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added tags, but where are the tags used? They are not added in the tutorial if I see that right

[step]
== Create the Quarkus project
--
executeCommand("mvn io.quarkus.platform:quarkus-maven-plugin:2.6.1.Final:create \"-DprojectGroupId=com.devonfw.quarkus\" \"-DprojectArtifactId=api-first-tutorial\" \"-Dextensions=resteasy-jackson\"","mvn io.quarkus.platform:quarkus-maven-plugin:2.6.1.Final:create -DprojectGroupId=com.devonfw.quarkus -DprojectArtifactId=api-first-tutorial -Dextensions=resteasy-jackson")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use the devon command to create the project?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The devon command can only create Spring projects at the moment. That's why I did it this way.

api-first-approach/files/create_pet.md Outdated Show resolved Hide resolved
api-first-approach/index.asciidoc Outdated Show resolved Hide resolved
api-first-approach/index.asciidoc Outdated Show resolved Hide resolved
api-first-approach/index.asciidoc Outdated Show resolved Hide resolved
@EduardKrieger EduardKrieger linked an issue Feb 7, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial for API first development devon4j – getting started - contract first
4 participants