Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: now checks all the characters of password for numbers #21

Closed
wants to merge 1 commit into from
Closed

Fix: now checks all the characters of password for numbers #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions demo/src/password_checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,15 @@ def check_strength(self, password):
feedback.append("Password should contain at least one uppercase letter")

# Bug: Incorrect number checking
if password[0].isdigit(): # Bug is here - only checks first character
score += 1
#fixed the bug by checking each character and finding if a number is present or not
for c in range(0,len(password)):
if password[c].isdigit():
score+=1
break
else:
feedback.append("Password should contain at least one number")



# Check for special characters
if any(c in self.special_chars for c in password):
Expand Down
Loading