7z_C build fix for Linux (and probably macos) #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the old asm does not compile on Linux anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is cherry-picked from my fork and Fixes #356
Tested the Windows build via wine and the Linux build on fully updated Arch Linux on a Ryzen5000 CPU.
I also build in CI for macos "intel" (amd64) and "m1" (arm64) and both builds succeed, I have no way of testing them though.
We may want to update the 7z_C lib in the future, but I am definitely too lazy to do that.
Since I'm already here, I've been wondering if there is a channel for discussion. Like a discord the maintainers are on, for example. The NESdev thread seems kinda dead and revenant1.net seem kinda outdated? I have some CI to create release builds and stuff and I've been wondering If upstream is interested in that and other stuff I've been working on.