Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kyle/fsspec integration #60

Conversation

martindurant
Copy link
Contributor

Running this test fails:

Exception: Generic S3 error: Error performing list request: Error after 0 retries in 39.083µs, max_retries:10, retry_timeout:180s, source:builder error for url (http://localhost:5555/test?delimiter=%2F&list-type=2)

even though that URI is gettable with requests, returning valid XML. Thoughts?

kylebarron and others added 18 commits October 23, 2024 12:47
* Streaming list results

* Collect remaining object metas

* Fused list stream

* Also fuse BytesStream

* fix tests

* Improve list docs
* Return list result as arrow

* Check if arro3-core is installed

* Add tests

* fix ci?

* update set up python

* downgrade requires python in test env

* Update list docstring examples
…lopmentseed#39)

* Return buffer protocol object from get_range and get_ranges

* Fix docs
* Support range in GetOptions

* Add test for get with options
* Rename package to object-store-py

* fix ci

* more renames
* Fix typing and docs website

* Update versions
* Rename to obstore

* more renames
* Add custom exceptions

* Add exceptions to docs
* Add put options

* Add put if not exists test
* remove `range` from `GetOptions` for now

* skip test
@kylebarron
Copy link
Member

even though that URI is gettable with requests, returning valid XML. Thoughts?

I think that usually means that it's falling back to instance authentication? Maybe we should default that to off for simpler errors

@martindurant
Copy link
Contributor Author

we should default that to off

How to do that?

@kylebarron
Copy link
Member

I think there'll be a bit of a learning curve for us to figure out the right set of auth configuration and ensure it's documented correctly.

So far, whenever I've hit auth errors, I've been able to re-check my credentials and get it working

* Add __repr__ to store classes

* Add __repr__ to pyi files

* containment
@kylebarron
Copy link
Member

#62 has an example of working tests against moto


def __init__(
self,
store: ObjectStore,
store,
Copy link
Member

@kylebarron kylebarron Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the ObjectStore typing here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't importing, and this is only typing. Perhaps something with my environment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's a type-only object. Perhaps it should be changed in the future to be an actual Python object that can be imported at runtime. The from __future__ import annotations should allow this to not be evaluated.

* wip use moto for tests

* edit

* Add basic tests with moto

* remove print

* anonymous s3 connection

* lint
@martindurant
Copy link
Contributor Author

Perfect, I'll build on that. "Unsigned" seems wrong, but oh well.

@kylebarron kylebarron mentioned this pull request Oct 30, 2024
@martindurant
Copy link
Contributor Author

Er, something has gone very wrong with my git here. I'll get back to it tomorrow with any luck.

@kylebarron
Copy link
Member

The branch you're trying to merge into is also behind. It's fine if you switch the target branch to main

@martindurant martindurant mentioned this pull request Oct 31, 2024
@kylebarron
Copy link
Member

I'll close this as I believe the only PR you intend to work on is #63, but reopen if I'm wrong.

@kylebarron kylebarron closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants