Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save 2 bytes #180

Closed
wants to merge 1 commit into from
Closed

Save 2 bytes #180

wants to merge 1 commit into from

Conversation

38elements
Copy link
Contributor

Before

 PASS  full/preact.js: 760B < maxSize 760B (gzip) 

 PASS  dist/unistore.js: 355B < maxSize 400B (gzip) 

 PASS  preact.js: 546B < maxSize 600B (gzip) 

After

 PASS  full/preact.js: 758B < maxSize 760B (gzip) 

 PASS  dist/unistore.js: 355B < maxSize 400B (gzip) 

 PASS  preact.js: 546B < maxSize 600B (gzip) 

This save 2 bytes.
BoundAction becomes returning void by this change.
It is breaking change.
But, BoundAction return void in type definition.
This behavior is not described in document.

export type BoundAction = (...args: any[]) => void;

https://github.com/developit/unistore#action

@lkmill
Copy link

lkmill commented Dec 27, 2019

hello stranger. i opened a couple of pull requests with rather substantial changes that i personally think greatly improves unistore and was looking for some feedback on. i'm assuming @developit is busy and meanwhile i was hoping to get this feedback from elsewhere. since you have opened a pull request yourself i assume you are familiar with the package and would love to hear what you think about the changes i propose. you can find them at #182 and #183. the second one builds upon the changes from the first.

@38elements 38elements closed this Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants