Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert: fix: resolve indefinitely queued (STOPPING_COMPLETED) trials #10207

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

tayritenour
Copy link
Contributor

@tayritenour tayritenour commented Nov 15, 2024

This PR causes issues where experiments that run a searcher then expect to save a checkpoint are thwarted by the master simply stopping the experiment before that happens.

Ticket

Description

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@tayritenour tayritenour requested a review from a team as a code owner November 15, 2024 20:44
@tayritenour tayritenour requested a review from hamidzr November 15, 2024 20:44
@cla-bot cla-bot bot added the cla-signed label Nov 15, 2024
@tayritenour tayritenour requested a review from stoksc November 15, 2024 20:44
Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit b4001c3
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6737c10f85d7f800083a60a2

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 53.88%. Comparing base (25179d0) to head (b4001c3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
master/internal/trial.go 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10207      +/-   ##
==========================================
- Coverage   54.55%   53.88%   -0.67%     
==========================================
  Files        1258     1257       -1     
  Lines      156530   156507      -23     
  Branches     3652     3652              
==========================================
- Hits        85393    84337    -1056     
- Misses      71004    72037    +1033     
  Partials      133      133              
Flag Coverage Δ
backend 46.06% <55.55%> (-0.04%) ⬇️
harness 67.37% <ø> (-3.78%) ⬇️
web 54.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
master/internal/trial.go 42.40% <55.55%> (-0.25%) ⬇️

... and 28 files with indirect coverage changes

---- 🚨 Try these New Features:

@tayritenour tayritenour enabled auto-merge (squash) November 15, 2024 20:50
@tayritenour tayritenour force-pushed the revert_c70dd8c1ad7c705c7cf768e6eca65d55e56ba089 branch from 6207fd1 to b4001c3 Compare November 15, 2024 21:45
@tayritenour tayritenour disabled auto-merge November 15, 2024 23:46
@tayritenour tayritenour merged commit 258455d into main Nov 15, 2024
75 of 89 checks passed
@tayritenour tayritenour deleted the revert_c70dd8c1ad7c705c7cf768e6eca65d55e56ba089 branch November 15, 2024 23:47
github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants