Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: log search #10203

Merged
merged 7 commits into from
Nov 13, 2024
Merged

revert: log search #10203

merged 7 commits into from
Nov 13, 2024

Conversation

gt2345
Copy link
Contributor

@gt2345 gt2345 commented Nov 12, 2024

Ticket

Description

Reverts log search UI and regex search

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@gt2345 gt2345 requested review from a team as code owners November 12, 2024 19:52
@cla-bot cla-bot bot added the cla-signed label Nov 12, 2024
@determined-ci determined-ci requested a review from a team November 12, 2024 19:52
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Nov 12, 2024
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 78ae8f9
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6733cdd71c02c2000805eb29
😎 Deploy Preview https://deploy-preview-10203--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gt2345 gt2345 requested a review from stoksc November 12, 2024 20:07
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 8.00000% with 23 lines in your changes missing coverage. Please review.

Project coverage is 54.54%. Comparing base (11a2581) to head (78ae8f9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../react/src/pages/TrialDetails/TrialDetailsLogs.tsx 10.00% 18 Missing ⚠️
master/internal/api_tasks.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10203      +/-   ##
==========================================
+ Coverage   54.37%   54.54%   +0.17%     
==========================================
  Files        1259     1258       -1     
  Lines      157346   156530     -816     
  Branches     3653     3652       -1     
==========================================
- Hits        85550    85374     -176     
+ Misses      71663    71023     -640     
  Partials      133      133              
Flag Coverage Δ
backend 46.06% <0.00%> (-0.11%) ⬇️
harness 71.14% <ø> (ø)
web 54.75% <10.00%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
master/internal/api_trials.go 57.22% <ø> (-0.05%) ⬇️
master/internal/db/postgres_filters.go 46.57% <ø> (-6.76%) ⬇️
master/internal/elastic/elastic_task_logs.go 0.00% <ø> (ø)
webui/react/src/services/decoder.ts 21.34% <ø> (+0.02%) ⬆️
webui/react/src/types.ts 99.70% <ø> (-0.01%) ⬇️
master/internal/api_tasks.go 50.20% <0.00%> (-2.16%) ⬇️
.../react/src/pages/TrialDetails/TrialDetailsLogs.tsx 15.86% <10.00%> (+4.75%) ⬆️

... and 10 files with indirect coverage changes

@gt2345 gt2345 merged commit 6feaddf into main Nov 13, 2024
83 of 96 checks passed
@gt2345 gt2345 deleted the gt/revert-log-search branch November 13, 2024 21:43
github-actions bot pushed a commit that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-0.38.0 cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants