Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix iris example to use reported metric name #10155

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

azhou-determined
Copy link
Contributor

@azhou-determined azhou-determined commented Oct 30, 2024

Ticket

Description

keras's metrics.categorical_accuracy is categorical_accuracy, not val_categorical_accuracy

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit f38e8f9
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/67225d43c1607700083f2d77

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.47%. Comparing base (4d75d94) to head (f38e8f9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10155      +/-   ##
==========================================
+ Coverage   54.26%   58.47%   +4.20%     
==========================================
  Files        1259      754     -505     
  Lines      157285   104301   -52984     
  Branches     3643     3642       -1     
==========================================
- Hits        85354    60987   -24367     
+ Misses      71798    43181   -28617     
  Partials      133      133              
Flag Coverage Δ
backend 43.80% <ø> (-2.12%) ⬇️
harness 71.15% <ø> (ø)
web 54.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 505 files with indirect coverage changes

@azhou-determined azhou-determined merged commit 9a30f26 into main Oct 30, 2024
83 of 99 checks passed
@azhou-determined azhou-determined deleted the fix-keras-example branch October 30, 2024 17:18
github-actions bot pushed a commit that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants