Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e add move Experiment row action test #10144

Merged
merged 10 commits into from
Oct 29, 2024
Merged

Conversation

thiagodallacqua-hpe
Copy link
Contributor

@thiagodallacqua-hpe thiagodallacqua-hpe commented Oct 28, 2024

Ticket

ET-663

Description

This Pr intends to add tests for the "move" experiment row action for the DataGrid.

Test Plan

  • run the 'Row Actions' test from the src/e2e/tests/experimentList.spec.ts test file.
  • all checks must pass

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit d461a2b
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/671fd38208bb140008d4ca3b
😎 Deploy Preview https://deploy-preview-10144--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thiagodallacqua-hpe thiagodallacqua-hpe marked this pull request as ready for review October 28, 2024 17:18
@thiagodallacqua-hpe thiagodallacqua-hpe requested review from a team as code owners October 28, 2024 17:18
@thiagodallacqua-hpe thiagodallacqua-hpe changed the title fix: Update action bar row layout in UserManagement page on mobile view fix: e2e add move Experiment row action test Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.75%. Comparing base (3eb656a) to head (d461a2b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10144      +/-   ##
==========================================
- Coverage   54.25%   50.75%   -3.51%     
==========================================
  Files        1259      953     -306     
  Lines      157257   130275   -26982     
  Branches     3642     3642              
==========================================
- Hits        85326    66121   -19205     
+ Misses      71798    64021    -7777     
  Partials      133      133              
Flag Coverage Δ
harness ?
web 54.29% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
webui/react/src/components/ExperimentMoveModal.tsx 65.70% <100.00%> (+0.28%) ⬆️

... and 309 files with indirect coverage changes

@thiagodallacqua-hpe thiagodallacqua-hpe enabled auto-merge (squash) October 29, 2024 13:38
@thiagodallacqua-hpe thiagodallacqua-hpe merged commit 8c95047 into main Oct 29, 2024
82 of 94 checks passed
@thiagodallacqua-hpe thiagodallacqua-hpe deleted the thiago/ET-663 branch October 29, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants