-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: e2e add move Experiment row action test #10144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thiagodallacqua-hpe
changed the title
fix: Update action bar row layout in UserManagement page on mobile view
fix: e2e add move Experiment row action test
Oct 28, 2024
johnkim-det
approved these changes
Oct 28, 2024
…opdown with move modal integration.
thiagodallacqua-hpe
force-pushed
the
thiago/ET-663
branch
from
October 28, 2024 18:10
c8fafb3
to
d461a2b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10144 +/- ##
==========================================
- Coverage 54.25% 50.75% -3.51%
==========================================
Files 1259 953 -306
Lines 157257 130275 -26982
Branches 3642 3642
==========================================
- Hits 85326 66121 -19205
+ Misses 71798 64021 -7777
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-663
Description
This Pr intends to add tests for the "move" experiment row action for the DataGrid.
Test Plan
'Row Actions'
test from thesrc/e2e/tests/experimentList.spec.ts
test file.Checklist
docs/release-notes/
See Release Note for details.