Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: determined_master_host and friends helm support, better defaults #10138

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

stoksc
Copy link
Contributor

@stoksc stoksc commented Oct 25, 2024

…rt, better defaults" (#10134)"

This reverts commit 782f7a0.

Ticket

DFR-529/530

Description

When determined_master_ip is unsettable via Helm and defaults to the service IP, life with proxies is hard. This change renames determined_master_ip to determined_master_host everywhere with some backwards compatibility, defaults determined_master_host to <det_namespace>.<det_service_name>.svc.cluster.local, and makes all of this overridable in Helm.

Reverted this, re-landing, had an embarrassing typo that broke everything.

Test Plan

Has automated tests, that's why I knew to revert.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Oct 25, 2024
@determined-ci determined-ci requested a review from a team October 25, 2024 22:20
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 18 lines in your changes missing coverage. Please review.

Project coverage is 54.73%. Comparing base (782f7a0) to head (1c0e1b2).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
master/cmd/determined-master/root.go 75.55% 11 Missing ⚠️
master/internal/config/resource_manager_config.go 55.55% 4 Missing ⚠️
master/internal/rm/kubernetesrm/jobs.go 71.42% 2 Missing ⚠️
...nal/rm/kubernetesrm/kubernetes_resource_manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10138      +/-   ##
==========================================
+ Coverage   54.71%   54.73%   +0.02%     
==========================================
  Files        1266     1266              
  Lines      159970   159989      +19     
  Branches     3662     3662              
==========================================
+ Hits        87525    87572      +47     
+ Misses      72312    72284      -28     
  Partials      133      133              
Flag Coverage Δ
backend 46.08% <72.72%> (+0.06%) ⬆️
harness 72.56% <ø> (ø)
web 54.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
master/internal/rm/kubernetesrm/job.go 77.31% <100.00%> (ø)
master/internal/rm/kubernetesrm/spec.go 84.64% <100.00%> (ø)
...nal/rm/kubernetesrm/kubernetes_resource_manager.go 27.67% <0.00%> (ø)
master/internal/rm/kubernetesrm/jobs.go 70.62% <71.42%> (ø)
master/internal/config/resource_manager_config.go 64.46% <55.55%> (-1.42%) ⬇️
master/cmd/determined-master/root.go 57.50% <75.55%> (+5.22%) ⬆️

... and 4 files with indirect coverage changes

@determined-ci determined-ci added the documentation Improvements or additions to documentation label Oct 25, 2024
Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 1c0e1b2
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/672023f5ddd8a50008cb7c41
😎 Deploy Preview https://deploy-preview-10138--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stoksc stoksc changed the title Revert "revert: "chore: determined_master_host and friends helm suppo… chore: determined_master_host and friends helm support, better defaults Oct 28, 2024
@stoksc stoksc marked this pull request as ready for review October 28, 2024 23:55
@stoksc stoksc requested review from a team as code owners October 28, 2024 23:55
@stoksc stoksc requested a review from maxrussell October 28, 2024 23:55
Copy link
Contributor

@maxrussell maxrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the previous PR I approved other than the DNS param order. Bradley's gonna wait for the GKE tests to run to merge.

@stoksc stoksc changed the title chore: determined_master_host and friends helm support, better defaults feat: determined_master_host and friends helm support, better defaults Oct 29, 2024
@stoksc stoksc merged commit 4e374c3 into main Oct 29, 2024
86 of 100 checks passed
@stoksc stoksc deleted the stoksc/k8s-det-host branch October 29, 2024 01:17
github-actions bot pushed a commit that referenced this pull request Oct 30, 2024
#10138)

When `determined_master_ip` is unsettable via Helm and defaults to the service IP, life with proxies is hard. This change renames `determined_master_ip` to `determined_master_host` everywhere with some backwards compatibility, defaults `determined_master_host` to `<det_namespace>.<det_service_name>.svc.cluster.local`, and makes all of this overridable in Helm.

(cherry picked from commit 4e374c3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-0.38.0 cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants