vets-api/v0.0.468

Release 0.0.468 ami-d3bbecb2

0bbdf7d move common raise_backend_exception method to base service class (#3376)

move common raise_backend_exception method to base service class

b80b687 remove EVSS prefix from source (#3381)

cfaacfd SSOe loa current (#3356)

• disable sso cookie for ssoe login

• infer loa_current from attributes

• fix up specs

• safe user navigation

• add coverage

• rubocop

• adjust specs

• add issuer rescue to catch failed login edge cases

• fix rubocop violation

4334742 Rubocop rspec fixes round 7 (#3384)

• Fixing Rubocop RSpec/EmptyLineAfterSubject offenses.

• Fixing Rubocop RSpec/HooksBeforeExamples offenses.

• Fixing Rubocop RSpec/ScatteredLet offense.

• Moving controller do block to fix Jenkins error.

30ba611 1092b update doc service version (#3309)

• Update document service version to 3.7

5ada784 remove itf validation from v0 claims controller (#3360)

• remove itf validation from v0 claims controller

• remove before action

• remove one more call to verifty_itf

• remove itf concern

• remove unneeded cassette calls

• updated tests for new rubocop rules

ddc8989 Jenkinsfile backward compatible for PR or Branch discovery (#3385)

08909ef testing jenkins CI flow (#3394)

• blahhhhhh

• 2nd commit

8431da6 Fixing Benefits Intake Uploader logic with retries (#3386)

• Fixing Uploader logic with retries

• rubocop fix

• rubocop fix

• quick refactor

• last fix

• making instance variable to reduce complexity and make it thread safe

• reducing complexity

471900c Use Fuubar formatter in rspec (#3380)

e5d05c7 1092c update evss common service version (#3315)

• Update evss common services to latest version

vets-api/v0.0.467

Release 0.0.467 ami-a52473c4

20efab7 PPIU error logging (#3366)

• create pii log on ppiu error

• use different method for saving req body

• lint

• lint

• dont use instance variables for log_exception

• rename save_req_body

08a867c Fixing Rubocop RSpec/LeadingSubject offenses. (#3372)

a5d5155 cbt/1137-validate_pdf.rb fix (#3346)

• validate_pdf fix

• added origami gem

• Gemfile.lock fix

• more Gemfile.lock fixes

• yet another

• formatting fixes

• code climate fixes

• ensure only pdfs are validated, not other filetypes

• reduce cognitive complexity hopefully

• validate temp_file is not nil

• add more detailed error messaging

• code climate fixes

• update tests

• check all pdfs with pdf extension

• linting error fixes

• remove unnecessary line

• rubocop offense fix

0c4a6f6 Add detail to User Profile swagger and remove redundant 'autn_context' attr (#3364)

• Add detail to User Profile swagger and remove redundant 'autn_context' attribute'

• style

• update swagger docs

8d65409 Sentry sign in tags must be strings, not a hash (#3373)

• Sentry sign in tags must be strings, not a hash

• style

a63349c Changing Benefits Intake data retention to from 3 to 10 (#3368)

• Changing Benefits Intake data retention to from 3 to 10

• fixing test

• fixing last test

• minor fix

ef92137 Upgrade brakeman gem (#3357)

• Remove obsolete brakeman ignore
• Add a brakeman ignore for our default of serializing cookies with :marshall
• Add additional warning about no SSL

7919eba Update factory_bot gem

784088d Update webmock gem

0764315 Update overcommit gem, which also upgraded rake gem

ab1441e 1995s - Spool submission report conditional recipients (#3349)

d0e710c Remove unused octokit gem

586479e Remove unused VCR cassette

vets-api/v0.0.466

Release 0.0.466 ami-44104725

a2fb5c9 Add Drivetime Bands Model (#3351)

• Add DrivetimeBand model and associate with VHAFacility

• Add drivetime band factories and specs

• Update 20190920134906_create_drivetime_bands.rb

• Update vha_facility_spec.rb

9c646bf Rubocop rspec fixes round 4 (#3365)

• Fixing Rubocop RSpec/ReturnFromStub offenses.

• Fixing Rubocop RSpec/SharedContext offenses.

• Fixing Rubocop RSpec/ReceiveCounts offenses.

16dba7b Fixing Rubocop RSpec/ExampleWording offenses. (#3367)

• Fixing Rubocop RSpec/ExampleWording offenses.

• Chenged names of two VCR cassettes to match wording change in specs.

• Fixing additional Rubocop RSpec/ExampleWording offenses.

• Fixing additional Rubocop offenses that occurred from merging master.

vets-api/v0.0.465

Release 0.0.465 ami-65c49004

1c40b08 Rubocop rspec fixes round 2 (#3354)

• Fixing Rubocop RSpec/EmptyLineAfterSubject offenses.

• Fixing Rubocop RSpec/EmptyLineAfterHook offenses.

• Fixing Rubocop RSpec/EmptyLineAfterFinalLet offenses.

• Fixing additional Rubocop RSpec/EmptyLineAfterFinalLet offenses.

• Fixing additional Rubocop RSpec/EmptyLineAfterHook offenses.

• Fixing Rubocop Rails/HttpStatus offenses.

• Fixing Rubocop RSpec/EmptyLineAfterFinalLet offense.

e40c11b Rubocop rspec fixes round 3 (#3361)

• Fixing Rubocop RSpec/ExpectChange offenses.

• Fixing Rubocop RSpec/ItBehavesLike offenses.

• Fixing Rubocop RSpec/NotToNot offenses.

• Fixing Rubocop RSpec/PredicateMatcher offenses.

8b4c19c Create drive time bands migration (#3358)

• Create 20190920134906_create_drivetime_bands.rb

• Update schema.rb

02f4973 Reorganize spec/support files (#3340)

• Move custom matchers to a single folder

• Remove unneeded .keep files

• Remove requires for spec_helper as its included by .rspec default

• Remove additional matcher requires

vets-api/v0.0.464

Release 0.0.464 ami-cc8bdfad

f0c7430 update rubyzip to address CVE-2019-16892 (#3355)

c1d890e VHA Facilities datasource switchover (#3339)

• Add dental services source for facilities (#3230)

• Add dental services source

• Remove DentalService column

• change services list from GIS to access to care (#3218)

• change services list from GIS to access to care

• Make rubocop happy

• merge the two parse service tests into one - per Kat

• Add facility dental service to redis (#3238)

• Create dental service job and Redis namespace

• Fix CSV

• Create and schedule job

• Lint

• Add test for removed keys

• Add test for error handling

• VHA Facilities from GIS (#3258)

• Add GIS calls

• Change facility validator and parser to work with new source

• Re-record casettes for fake gis.va.gov

• Remove vestigial mh_clinic_phone method

• Change name of service mapping methods and mappings for vha and vba

• Rt/facilities websites (#3265)

• Add WebsiteUrlService

• Integrate website url service with vha data pull

• Kr/get all vha services from redis (#3269)

• Add dental services from redis

• Add dental services and take out old arcgis code

• Update services update time, major refactor

• Make rubocop happy

• Rename tempfacility attributes

• Change middleware, take out attr_accessor in facility parser

• Add mobile flag to Facilities API (#3293)

• Add mobile flag to Facilities API

• Remove deprecation warnings about RSpec matcher

• Fix deprecations in specs
  Remove mobile flag from non-vha facility factories
  Better convey that vha should have non-nil mobile attribute

• add stubbed sql52 for local development (#3310)

• add sql52 to docker compose setup used in docker setup of vets-api and instructions for native setup

• Revert "add sql52 to docker compose setup used in docker setup of vets-api and instructions for native setup"

This reverts commit 53e2b23

• add SQL52 information in facilities specific readme

• update configuration in readme

• add schema_name

• Filter out Vet Centers and Mobile Vet Centers (#3314)

• Exclude vet centers and mobile vet centers

• Update cassettes for new query

• Add active_status to Facilities API (#3306)

• Add active_status column migration

• Add active_status to FacilityParser

• Update serializers

• Add active_status request tests

• Update documentation

• Run migration

• Add VHA facility to example CSV response

• Revert Add active_status column migration

• Get merge conflict out of schema

• mapping classification for VHA (#3327)

• mapping classification for VHA

• cleaning up logic

• Kr/add mental health etl download job (#3308)

• Add redis store and download job for mental health

• Smol refactor to dental service job

• Add mental health to vha facility model, add tests

• Update config with real stuff

• Fix configs

• Update config/settings.yml

Co-Authored-By: Nick Fasulo [email protected]

• Update config/settings.yml

Co-Authored-By: Nick Fasulo [email protected]

• Add job to scheduler

• Make rubocop happy I think

• Update jobs.rake (#3335)

• Move the "new" method call to the end of download chain (#3338)

• make rubocop like me

• Handle lowercase StationNum in websites.csv (#3341)

• Kr/refactor logging and constants (#3343)

• Refactoring

• Remove unused configs

• Refactor sentry tests

• Update variable names

• Add 564BY, remove 612QA, and sort by unique_id

• Make hours map constant a literal frozen hash for easier readability

• Remove sql52 docker info (#3344)

• remove the sql52 docker image and replace with sidekiq job

• make rubocop happy

• PR suggestions

• PR suggestions

• Update mental_health_reload_job.rb

• Undo sentry test changes in download job specs

• Remove unused comments

• Remove excess expectations for rubocop

• Delete commented out expectations

• Gis client testing (#3352)

• gis client testing

• mock Faraday instead of sut

• reformat code

• use allow instead of expect on double

• PR suggestions

• PR suggestions

• update vulnerable gem

• revert bundle with version

• remove more unused comments

• Update lib/common/client/middleware/response/facility_parser.rb

Co-Authored-By: Johnny Holton [email protected]

• remove whitespace

3cf12cc MVI upgrade to versionCode 4.1 (#3219)

• in MVI message builder, bump versionCode from 3.0 to 4.1
• Swap MVI 'AE' and 'AR' response code paths to more accurately reflect their use cases.
• change mvi/responses/id_parser to only select the "Active" Vet360 ID
• Update cassettes and fixtures
• Clean up specs: remove unused fixtures and duplicate specs. Rename fixtures/cassettes for clarity.

vets-api/v0.0.463

Release 0.0.463 ami-f8085c99

bf86e5e Major corrections and changes to Claims API documentation (#3347)

• Major corrections and changes to Claims API documentation

• updated Claims show model

• rubocop fix

• api docs fix

8e4216a Add sanitizer to he EVSS VA representative field (#3077)

b329f7e Updating Benefits Documentation (#3353)

• Updating Benefits Documentation

• minor claims support link addon

vets-api/v0.0.462

Release 0.0.462 ami-d81b4fb9

3ac89a8 Rubocop rspec fixes round 1 (#3348)

• Fixing Rubocop Rspec FactoryBot/CreateList offenses.

• Fixing Rubocop Rspec RSpec/BeEql offenses.

• Fixing Rubocop RSpec/EmptyLineAfterExampleGroup offenses.

• Fixing Rubocop RSpec/LetBeforeExamples offenses.

• Removing comments from .rubocop_todo.yml.

vets-api/v0.0.461

Release 0.0.461 ami-24f7a245

5e5cdc5 Rubocop offenses (#3330)

• Fixing Rubocop Style/MultipleComparison offenses. Also moving some exclusions over to .rubocop.yml

• Fixing Rubocop Style/RedundantReturn offenses.

• moving remaining todos over to .rubocop.yml

• Removing .rubocop_todo.yml

• Disabling Naming/UncommunicativeMethodParamName in .rubocop.yml and moving some items back to rubocop_todo.yml.

• Fixing Rubocop Lint/SafeNavigationWithEmpty offense.

• Fixing Rubocop Security/Open offense.

• Fixing Rubocop Naming/RescuedExceptionsVariableName offense.

• adding rubocop yaml files to exclude patterns in codeclimate

• removing commented out code from .rubocop_todo.yml

• refactor code to comply with Rubocop (#3337)

• Refactoring code in lib/sm/client.rb to fix Rubocop Style/AccessModifierDeclarations offense.

• Refactoring code to fix Rubocop Style/AccessModifierDeclarations offenses.

cbd43d7 1092 update service version (#3303)

• Update claims status service to new EVSS API version

ec7a554 Adding rubocop rspec gem (#3342)

• added rubocop-rspec gem

• generated .rubocop_todo.yml

309025c Update to FactoryBot 4.11 in preparation for 5.0 upgrade

• Remove unncessary Timecop that led to incorrect/false negative results

The dynamic vs static generation of the time had some side effects here
which could be clearly and consistently fixed. Also only put Timecop
in the specs it was actually needed on. One less surprise.

• Update a newly added factory to FactoryBot 5 syntax

25bcd00 Update to FactoryBot 5.0

Fix two specs that need to create instead of build their factory to
successfully lint it new release of gem

b3b4ddb Update to Factorybot 5.1

02b197e Allow FactoryBot factory files to have multiline {...} blocks as is convention instead of rewriting into do/end

eeb0b2b Rename support file from factory_girl file to factory_bot

vets-api/v0.0.460

Release 0.0.460 ami-37a7f256

8465942 Temporarily set loa_highest to loa_current (#3331)

• temporarily set loa_highest to loa_current

• pass specs

939b59e Adding PDF Generation Disabled to schema (#3328)

• Adding PDF Generation Disabled to schema

• adding pdf overwrite to other models

• fixing response

85ae261 Flush stdout to display error output in jenkins (#3320)

Set the stdout flush sync mode to true

When sync mode is true, all output is immediately flushed to the underlying operating system and is not buffered internally

7893352 Security vulnerability no longer poses issue after Rails 5.2.2.1 (#3334)

• remove --ignore CVE-2019-5420 after updating to rails 5.2

A remote code execution vulnerability in development mode Rails <5.2.2.1, <6.0.0.beta3 can allow an attacker to guess the automatically generated development mode secret token. This secret token can be used in combination with other Rails internals to escalate to a remote code execution exploit.

ee321cd adding the rubocop yaml files to the codeclimate exclude patterns (#3336)

vets-api/v0.0.459

Release 0.0.459 ami-1d782d7c

fa791db Direct deposit sentry filter (#3304)

• working on filter feq body spec

• finilsh filter req body spec

• lint

• use dig for stringified data

• use dig for sanitized data

• add sanitize method

• change spec to with data from a controller in FILTERED_CONTROLLER

• change data variable to sentry data

• Refactor the specs for clarity (#3329)

• Duplicate existing specs

• Remove previous specs

• Promote client and processor to before(:each)

• Refactor sentry setup into method

• Parameterize method with focus of spec, rename for clarity

• Wordsmithing

6267a1d SAML Okta hook (#3326)

• okta wip

• wip okta controller with hook

• wip stashing work

• add comments

• wip

• update notes

• Processing okta response, MIV lookup WIP

• MVI query wired up correctly

• Move OktaController inside openid_auth module

• Remove unnecessary identity param

• add okta json request json

• add additional attributes for MVI lookup

• add preliminary test and format okta json

• remove ignored json return attribute

• Remove unused function

• Autofixable linting errors

• Remove localhost workaround for okta

• Refactor to utility methods to build JSON

• Linting fixes

• More linting fixes

• fix request specs

• add okta docs

• add docs coverage; rename missnamed file

• pass openauth docs spec

• Fix linting error

196146b Fix locally broken spec

There is a repeatable and persistent spec failure on multiple (all?)
local Ruby installations in this location: /spec/controllers/v0/preneeds/preneed_attachments_controller_spec.rb:7

The stacktrace is

2019-09-18 09:49:15.919951 D [28322:70295016921020] V0::Preneeds::PreneedAttachmentsController -- Processing #create
2019-09-18 09:49:19.287652 E [28322:70295016921020 sentry_logging.rb:57] Rails -- Failed to manipulate with MiniMagick, maybe it is not an image? Original Error: `identify /var/folders/yj/9j91j4gj2sqbkll8mrxy3h8r0000gn/T/mini_magick20190918-28322-1f7ayhd.pdf` failed with error:
.
2019-09-18 09:49:19.287793 E [28322:70295016921020 sentry_logging.rb:57] Rails -- /Users/johnpaul/work/oddball/vets-api/.bundle/gems/carrierwave-0.11.2/lib/carrierwave/processing/mini_magick.rb:273:in `rescue in manipulate!'
/Users/johnpaul/work/oddball/vets-api/.bundle/gems/carrierwave-0.11.2/lib/carrierwave/processing/mini_magick.rb:258:in `manipulate!'
/Users/johnpaul/work/oddball/vets-api/.bundle/gems/carrierwave-0.11.2/lib/carrierwave/processing/mini_magick.rb:108:in `convert'
/Users/johnpaul/work/oddball/vets-api/.bundle/gems/carrierwave-0.11.2/lib/carrierwave/uploader/processing.rb:84:in `block in process!'
/Users/johnpaul/work/oddball/vets-api/.bundle/gems/carrierwave-0.11.2/lib/carrierwave/uploader/processing.rb:76:in `each'
/Users/johnpaul/work/oddball/vets-api/.bundle/gems/carrierwave-0.11.2/lib/carrierwave/uploader/processing.rb:76:in `process!'
/Users/johnpaul/work/oddball/vets-api/.bundle/gems/carrierwave-0.11.2/lib/carrierwave/uploader/callbacks.rb:18:in `block in with_callbacks'
/Users/johnpaul/work/oddball/vets-api/.bundle/gems/carrierwave-0.11.2/lib/carrierwave/uploader/callbacks.rb:18:in `each'
/Users/johnpaul/work/oddball/vets-api/.bundle/gems/carrierwave-0.11.2/lib/carrierwave/uploader/callbacks.rb:18:in `with_callbacks'
/Users/johnpaul/work/oddball/vets-api/.bundle/gems/carrierwave-0.11.2/lib/carrierwave/uploader/cache.rb:134:in `cache!'
/Users/johnpaul/work/oddball/vets-api/.bundle/gems/carrierwave-0.11.2/lib/carrierwave/uploader/store.rb:56:in `store!'
/Users/johnpaul/work/oddball/vets-api/app/models/form_attachment.rb:15:in `set_file_data!'
/Users/johnpaul/work/oddball/vets-api/app/controllers/concerns/form_attachment_create.rb:14:in `create'

but the real issue stems from the preneed_attachment_uploader

  process(convert: 'pdf', if: :not_pdf?)
...
  def not_pdf?(file)
    file.content_type != 'application/pdf'
  end

This tries to process the uploaded file if its not a PDF. The fixture was
being uploaded without a specified type, which evaluated to "" and triggered
the PDF conversion process. This process failed because the file was not an
image.

Staging possibly works because of a different minimagick/ImageMagick
version with different rules?