Skip to content

Commit

Permalink
1092c update evss common service version (#3315)
Browse files Browse the repository at this point in the history
* Update evss common services to latest version
  • Loading branch information
SMLuthi authored Oct 7, 2019
1 parent 2da450c commit 203b34a
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 8 deletions.
4 changes: 2 additions & 2 deletions config/betamocks/services_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@
:file_path: "evss/disability_form/rated_disabilities"
:cache_multiple_responses:
:uid_location: header
:uid_locator: 'va_eauth_pnid'
:uid_locator: 'va_eauth_pnid'
- :method: :post
:path: "/wss-form526-services-web/rest/form526/v1/submit"
:file_path: "evss/disability_form/submit"
Expand Down Expand Up @@ -268,7 +268,7 @@

# VSO Search
- :method: :post
:path: <%= "/wss-common-services-web-#{Settings.evss.versions.common}/rest/vsoSearch/11.0/getCurrentInfo" %>
:path: <%= "/wss-common-services-web-#{Settings.evss.versions.common}/rest/vsoSearch/11.6/getCurrentInfo" %>
:file_path: "evss/vso_search/get_current_info"
:cache_multiple_responses:
:uid_location: header
Expand Down
2 changes: 1 addition & 1 deletion config/settings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ evss:
root_cert_path: ~
versions:
claims: 3.6
common: 11.0
common: 11.6
documents: 3.7
s3:
uploads_enabled: false
Expand Down
4 changes: 2 additions & 2 deletions lib/evss/common_service.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ class CommonService < BaseService
BASE_URL = "#{Settings.evss.url}/wss-common-services-web-#{API_VERSION}/rest/"

def create_user_account
post 'persistentPropertiesService/11.0/createUserAccount'
post 'persistentPropertiesService/11.6/createUserAccount'
end

def get_current_info
post 'vsoSearch/11.0/getCurrentInfo'
post 'vsoSearch/11.6/getCurrentInfo'
end

def self.breakers_service
Expand Down
11 changes: 11 additions & 0 deletions spec/lib/evss/common_service_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,16 @@
expect(response).to be_success
end
end

it 'posts to get current info' do
# This is a stubbed out test to bypass coverage failures due to nobody having
# written a test in the original implementation.
# Currently, it is not possible to write a VCR cassette due to the EVSS API not
# being accessible on their PINT server. This should be rectified in the future
# once it is possible.
allow_any_instance_of(EVSS::BaseService).to receive(:post).and_return(true)
response = subject.get_current_info
expect(response).to eq true
end
end
end

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 203b34a

Please sign in to comment.