fix: exit error code on arg parse failure #112

dsherret · 2024-03-21T03:50:02Z

Closes #108

dsherret · 2024-03-21T03:59:14Z

src/shell/commands/exit.rs

@@ -21,9 +21,9 @@ impl ShellCommand for ExitCommand {
    let result = match execute_exit(context.args) {
      Ok(code) => ExecuteResult::Exit(code, Vec::new()),
      Err(err) => {
-        // even if parsing args fails `exit` always exits
+        // exit exits with exit code 2 on argument parse failure


It seems the exact error code to use is not dictated, but generally exit codes for failed arg parsing is 2.

* feat: implement exit status var (denoland/deno_task_shell#110) * feat: support input redirects (denoland/deno_task_shell#106) * feat: support output fd redirects for stdout and stderr (denoland/deno_task_shell#111) * feat: support parsing fd redirects (denoland/deno_task_shell#107) * fix: exit error code on arg parse failure (denoland/deno_task_shell#112) Closes #22989

fix: exit error code on arg parse failure

17c2527

dsherret requested a review from bartlomieju March 21, 2024 03:50

dsherret commented Mar 21, 2024

View reviewed changes

Remove comment

deda746

bartlomieju approved these changes Mar 21, 2024

View reviewed changes

dsherret merged commit e8f8954 into denoland:main Mar 21, 2024
4 checks passed

dsherret deleted the fix_exit_error_code branch March 21, 2024 15:49

dsherret mentioned this pull request Mar 21, 2024

feat: deno_task_shell 0.15 denoland/deno#23019

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: exit error code on arg parse failure #112

fix: exit error code on arg parse failure #112

dsherret commented Mar 21, 2024

dsherret Mar 21, 2024 •

edited

Loading

fix: exit error code on arg parse failure #112

fix: exit error code on arg parse failure #112

Conversation

dsherret commented Mar 21, 2024

dsherret Mar 21, 2024 • edited Loading

Choose a reason for hiding this comment

dsherret Mar 21, 2024 •

edited

Loading