[Kernel] Remove Coordinated Commits from public API #3938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottsand-db
requested review from
vkorukanti,
prakharjain09,
allisonport-db and
dhruvarya-db
allisonport-db
approved these changes
Dec 10, 2024
scottsand-db
force-pushed
the
kernel_remove_coordinated_commits_from_public_api
branch
from
c3ea45b to
7c47c5a
Compare
scottsand-db
added a commit
to scottsand-db/delta
that referenced
this pull request
Dec 13, 2024
- [ ] Spark - [ ] Standalone - [ ] Flink - [X] Kernel - [ ] Other (fill in here) We are re-thinking the design of the Coordinated Commits table feature (currently still in RFC). Thus, we should remove it from the public Kernel API for Delta 3.3 release. To summarize the changes of this PR - I remove `getCommitCoordinatorClientHandler` from the `Engine` interface - I move various previously `public` CC interfaces and classes to be `internal` now - `SnapshotImpl::getTableCommitCoordinatorClientHandlerOpt` is hardcoded to return an empty optional - Delete failing test suites and unapplicable utils Existing CI tests. We remove coordinated commits from the public kernel API.
scottsand-db
added a commit
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
We are re-thinking the design of the Coordinated Commits table feature (currently still in RFC). Thus, we should remove it from the public Kernel API for Delta 3.3 release.
To summarize the changes of this PR
getCommitCoordinatorClientHandlerfrom theEngineinterfacepublicCC interfaces and classes to beinternalnowSnapshotImpl::getTableCommitCoordinatorClientHandlerOptis hardcoded to return an empty optionalHow was this patch tested?
Existing CI tests.
Does this PR introduce any user-facing changes?
We remove coordinated commits from the public kernel API.