[Spark] Current Date/Time resolution in constraints #2766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaschat-db
changed the title
andreaschat-db
changed the title
cloud-fan
reviewed
Mar 19, 2024
spark/src/main/scala/org/apache/spark/sql/delta/constraints/DeltaInvariantCheckerExec.scala
Show resolved
Hide resolved
andreaschat-db
changed the title
cloud-fan
approved these changes
Mar 20, 2024
tdas
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
This is great. Thank you for making this such that it will work with both spark master and 3.5.
My only worry is that we are using optimizer.ComputeCurrentTime .. which is spark internal API, and there is a risk that this is not going to stable across spark versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Heading towards the removal of codegenFallback from Date/Time expressions (apache/spark#44261), delta constraints need to resolve current_datetime expressions during the analysis of the invariants. The proposed changes work for both Spark 3.5 and Spark master.
How was this patch tested?
Existing tests. In particular,
CheckConstaintsSuitecovers constraints withcurrent_timestamp()expressions. Added an extra test to covercurrent_date().Does this PR introduce any user-facing changes?
No.