Petlevels #2
Open
Petlevels #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update for each display button not just buttons that there is an existing text for. This fixes item levels not showing when changing settings that would display more labels.
Going through a load screen doesn't do a full reloadUI, but adibags handles the changes by calling Disable and then Enable. OnDisable all the text is hidden, so OnEnable the cache needs to be wiped so that the text can be shown as needed. This fixes item levels not being show after a loading screen.
|
Ah @legowxelab2z8 I missed the notification for this pull request somehow - sorry. Up to you how to proceed - as petlevels was already merged and the "wipe cache OnEnable" bit was fixed already (except onDisable). I was planning this week to open a PR from this branch with some additional improvements to the item level calculation if you wanted to submit the SetOptionAndUpdate changes there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for two bugs with the refactor of UpdateButton.
Fix 1 Changes SetOptionAndUpdate to update each displayed button not just buttons that there is an existing text for. This fixes item levels not showing when changing settings that would cause more text to be displayed.
Fix 2 Wipe cache OnEnable. Going through a load screen doesn't do a full reloadUI, but adibags handles the changes by calling Disable and then Enable. OnDisable all the text is hidden, so OnEnable the cache needs to be wiped so that the text can be shown as needed. This fixes item levels not being show after a loading screen.